Skip to content

Expand the set of mutual PartialEq and PartialOrd impls for OsStr[ing] and Path[Buf] #31751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 23, 2016
Merged

Expand the set of mutual PartialEq and PartialOrd impls for OsStr[ing] and Path[Buf] #31751

merged 4 commits into from
Feb 23, 2016

Conversation

gkoz
Copy link
Contributor

@gkoz gkoz commented Feb 18, 2016

No description provided.

@rust-highfive
Copy link
Contributor

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@gkoz
Copy link
Contributor Author

gkoz commented Feb 20, 2016

r? @aturon

@rust-highfive rust-highfive assigned aturon and unassigned brson Feb 20, 2016
@aturon
Copy link
Member

aturon commented Feb 22, 2016

Thanks for the PR!

@brson, would you mind doing a crater run on this PR? Just want to gauge whether this has any significant inference fallout.

@alexcrichton alexcrichton added the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Feb 22, 2016
@alexcrichton
Copy link
Member

Crater reports zero regressions (a number of unknown ones though)

@alexcrichton alexcrichton removed the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Feb 23, 2016
@aturon
Copy link
Member

aturon commented Feb 23, 2016

I'm sad this is necessary, but let's do it. Thanks again @gkoz!

@bors: r+

@bors
Copy link
Collaborator

bors commented Feb 23, 2016

📌 Commit 409bffa has been approved by aturon

bors added a commit that referenced this pull request Feb 23, 2016
@bors
Auto merge of #31751 - gkoz:os_str_path_cmp, r=aturon
43ddfbd
@bors
Copy link
Collaborator

bors commented Feb 23, 2016

⌛ Testing commit 409bffa with merge 43ddfbd...

@bors
Copy link
Collaborator

bors commented Feb 23, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-mac-ios-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

@bors bors merged commit 409bffa into rust-lang:master Feb 23, 2016
@gkoz gkoz mentioned this pull request Feb 24, 2016
Closed
@thaliaarchi thaliaarchi mentioned this pull request Apr 6, 2025
Open
thaliaarchi added a commit to thaliaarchi/rust that referenced this pull request Apr 6, 2025
@thaliaarchi
Implement AsRef<OsStr> for Cow<'_, Path>
781b92c 
In rust-lang#31751, `impl AsRef<Path> for Cow<'_, OsStr>` was added, but the
converse was omitted and it wasn't mentioned in discussion. This seems
to have been a simple oversight, as it otherwise implemented traits
mutually between `OsStr` and `Path`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aturon aturon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gkoz @rust-highfive @aturon @alexcrichton @bors @brson