-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Rollup PRs in the queue #21855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Rollup PRs in the queue #21855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valgrind files moved and modpath.iss deleted. Both entries updated in COPYRIGHT file. Signed-off-by: Luca Bruno <[email protected]>
These methods were intended to be stable as of rust-lang#16258 but the tags have since been lost in various refactorings. This commit re-adds the `#[stable]` attributes to each of these functions.
When it was un*known*_features it was reasonably to by deny by default. cc rust-lang#21798
http://doc.rust-lang.org/rustdoc.html states that its content was moved to http://doc.rust-lang.org/book/documentation.html
Changed in 64ca751
Unicode escapes were changed in [this RFC](https://github.com/rust-lang/rfcs/blob/28aeb3c391c9afd344f124d3a69bdc2a420638b2/text/0446-es6-unicode-escapes.md) to use the ES6 \u{00FFFF} syntax with a variable number of digits from 1-6, eliminating the need for two different syntaxes for unicode literals.
…ords in view path idents
Now that associated types are fully implemented the iterator adaptors only need type parameters which are associated with actual storage. All other type parameters can either be derived from these (e.g. they are an associated type) or can be bare on the `impl` block itself. This is a breaking change due to the removal of type parameters on these iterator adaptors, but code can fairly easily migrate by just deleting the relevant type parameters for each adaptor. Other behavior should not be affected. Closes rust-lang#21839 [breaking-change]
There [have been reports][issue] of an unconditional warning causing tooling to go awry. This isn't actually a warning per se, it's more of a note anyway! [issue]: rust-lang/cargo#1260 Closes rust-lang/cargo#1260
…hton syntax like `use foo::bar::;` and `use foo:: as bar;` should be rejected, see issue rust-lang#21629
…excrichton Unicode escapes were changed in [this RFC](https://github.com/rust-lang/rfcs/blob/28aeb3c391c9afd344f124d3a69bdc2a420638b2/text/0446-es6-unicode-escapes.md) to use the ES6 \\u{00FFFF} syntax with a variable number of digits from 1-6, eliminating the need for two different syntaxes for unicode literals. I have updated The Reference and grammar.md to reflect these changes.
as titled. See issue rust-lang#21770
http://doc.rust-lang.org/rustdoc.html states that its content was moved to http://doc.rust-lang.org/book/documentation.html
When it was un*known*_features it was reasonable to be deny by default. cc rust-lang#21798 r? @alexcrichton
…, r=huonw These methods were intended to be stable as of rust-lang#16258 but the tags have since been lost in various refactorings. This commit re-adds the `#[stable]` attributes to each of these functions.
valgrind files moved and modpath.iss deleted. Both entries updated in COPYRIGHT file. Signed-off-by: Luca Bruno <[email protected]>
There [have been reports][issue] of an unconditional warning causing tooling to go awry. This isn't actually a warning per se, it's more of a note anyway! [issue]: rust-lang/cargo#1260 Closes rust-lang/cargo#1260
Now that associated types are fully implemented the iterator adaptors only need type parameters which are associated with actual storage. All other type parameters can either be derived from these (e.g. they are an associated type) or can be bare on the `impl` block itself. This is a breaking change due to the removal of type parameters on these iterator adaptors, but code can fairly easily migrate by just deleting the relevant type parameters for each adaptor. Other behavior should not be affected. Closes rust-lang#21839 [breaking-change]
Check that, #21808 is reviewed |
@bors: r+ 14ca6d9 rollup |
@bors: rollup- |
@bors: p=10 |
⌛ Testing commit 14ca6d9 with merge 53bb848... |
💔 Test failed - auto-mac-64-nopt-t |
@bors r+ b27f2d3 |
⌛ Testing commit b27f2d3 with merge f4b4568... |
💔 Test failed - auto-mac-64-opt |
Thanks @Manishearth! I've continued this in #21872, but I forgot to base it off this :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: The currently merged version of #21808 isn't reviewed
r? @huonw