-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Fix end of TtDelimited span #21825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix end of TtDelimited span #21825
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
use syntax::ast; | ||
use std::borrow::ToOwned; | ||
|
||
pub fn main() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this live in libsyntax's tests instead of run-pass? It looks like its specifically testing part of the syntax crate as opposed to the compiler as a whole.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering that, but I couldn't find a great place to put it. Somehow it seems wrong to stick a single #[test]
function after 6,000 lines of parser code but... one is better than none, I guess. If there are parser-related tests elsewhere I didn't find them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some tests here and there, particularly in ext::expand
. Not sure where this would fit. A 6,000 line file is unfortunate, but that's a different problem IMO :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might rather create parser_test.rs
then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM
There are some |
Thanks! |
fa5b4b0
to
cedc675
Compare
Updated with new test. |
No description provided.