Skip to content

Fix end of TtDelimited span #21825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2015
Merged

Conversation

kmcallister
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

use syntax::ast;
use std::borrow::ToOwned;

pub fn main() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this live in libsyntax's tests instead of run-pass? It looks like its specifically testing part of the syntax crate as opposed to the compiler as a whole.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering that, but I couldn't find a great place to put it. Somehow it seems wrong to stick a single #[test] function after 6,000 lines of parser code but... one is better than none, I guess. If there are parser-related tests elsewhere I didn't find them.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some tests here and there, particularly in ext::expand. Not sure where this would fit. A 6,000 line file is unfortunate, but that's a different problem IMO :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might rather create parser_test.rs then.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@sanxiyn
Copy link
Member

sanxiyn commented Feb 1, 2015

There are some #[test] functions in src/libsyntax/parse/mod.rs.

@kmcallister
Copy link
Contributor Author

Thanks!

@kmcallister
Copy link
Contributor Author

Updated with new test.

@sanxiyn
Copy link
Member

sanxiyn commented Feb 1, 2015

@bors r+ cedc675

Manishearth added a commit to Manishearth/rust that referenced this pull request Feb 2, 2015
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Feb 2, 2015
@bors bors merged commit cedc675 into rust-lang:master Feb 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants