Skip to content

Wrong name used in code example in Rust reference #21770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dsyang opened this issue Jan 30, 2015 · 3 comments
Closed

Wrong name used in code example in Rust reference #21770

dsyang opened this issue Jan 30, 2015 · 3 comments

Comments

@dsyang
Copy link
Contributor

dsyang commented Jan 30, 2015

In the Use Declarations section of the rust reference manual (http://doc.rust-lang.org/reference.html#use-declarations), the third code example has the following line
// use core::iter; // bad: native is not at the crate root
I think the comment should read:
// bad: core is not at the crate root or something else. It shouldn't reference native because native isn't used anywhere in the code example.

@dsyang
Copy link
Contributor Author

dsyang commented Jan 30, 2015

I'd be willing to submit a PR if someone could check to see if my reasoning is correct.

@steveklabnik
Copy link
Member

When in doubt, the reference is probably wrong 😉 I have it scheduled to update during the beta period, and so I believe you are correct. A PR would be great, thanks!=

Manishearth added a commit to Manishearth/rust that referenced this issue Feb 1, 2015
alexcrichton added a commit to alexcrichton/rust that referenced this issue Feb 2, 2015
@alexcrichton
Copy link
Member

Fixed in #21819

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants