Skip to content

Add support for run-pass-valgrind tests #17868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 23, 2014
Merged

Add support for run-pass-valgrind tests #17868

merged 5 commits into from
Oct 23, 2014

Conversation

nrc
Copy link
Member

@nrc nrc commented Oct 8, 2014

@rust-highfive
Copy link
Contributor

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!

alexcrichton
alexcrichton reviewed Oct 8, 2014
View reviewed changes
src/compiletest/runtest.rs
fatal_proc_rec("compilation failed!", &proc_res);
}

println!("running valgrind");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stray println

@nrc
Copy link
Member Author

nrc commented Oct 8, 2014

Addressed comments. This would mean that we are essentially adding a dependency on Valgrind for anyone who wants to build rust and run the tests. Are we comfortable with that?

r? @alexcrichton

@alexcrichton
Copy link
Member

@brson, how do you feel about requiring valgrind for OSX/Linux when running tests?

@nrc
Copy link
Member Author

nrc commented Oct 16, 2014

@alexcrichton @brson

I tweaked things so that if a user configures with --disable-valgrind, then we don't fail valgrind tests if there is no valgrind. So it should still fail on the servers, but Linux users who don't have valgrind still have an out for running tests (albeit a non-obvious one).

What do you think?

@alexcrichton
Copy link
Member

@nick29581 I've installed valgrind on the mac bots now, but it only works for 64 bit. I think that compiling valgrind for 32-bit is difficult and I've seen that it doesn't work so hot there apparently.

Could you update this to disable valgrind for 32-bit on osx as well? Other than that r=me

bors added a commit that referenced this pull request Oct 20, 2014
@bors
auto merge of #17868 : nick29581/rust/valgrind, r=alexcrichton
addc172 
r? @alexcrichton
@nrc nrc force-pushed the valgrind branch 2 times, most recently from 1bf1782 to 8c0ed8d Compare October 23, 2014 00:51
@nrc nrc force-pushed the valgrind branch 3 times, most recently from 8cf1b2d to 9e822d5 Compare October 23, 2014 01:17
@nrc
Copy link
Member Author

nrc commented Oct 23, 2014

@alexcrichton re-r? please? I changed the process quite a bit with the last iteration.

bors added a commit that referenced this pull request Oct 23, 2014
@bors
auto merge of #17868 : nick29581/rust/valgrind, r=alexcrichton
8a40854 
r? @alexcrichton
@bors bors closed this Oct 23, 2014
@bors bors merged commit 80ff1d1 into rust-lang:master Oct 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nrc @rust-highfive @alexcrichton @bors