Skip to content

Add run-pass-valgrind tests #16914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nrc opened this issue Sep 1, 2014 · 0 comments
Closed

Add run-pass-valgrind tests #16914

nrc opened this issue Sep 1, 2014 · 0 comments

Comments

@nrc
Copy link
Member

nrc commented Sep 1, 2014

I would like some rpass to always be run under Valgrind. These are mostly cleanup tests, to check that all memory is freed and we don't double free memory.

I propose adding a directory to tests - run-pass-valgrind. Any tests inside are treated like run-pass tests, but on systems with Valgrind (which should include the bots with every push) all tests are run under Valgrind (maybe as well as without Valgrind, or maybe just with Valgrind, not sure if there is benefit to running without). The test fails if it fails to compile, a task fails (as with regular run-pass tests), or there are any Valgrind errors. On systems without Valgrind, they should be run like the regular run-pass tests.

nrc added a commit to nrc/rust that referenced this issue Oct 20, 2014
@nrc nrc closed this as completed in f466e1a Oct 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant