Skip to content

Add test scaffolding for the remote-test-client #149071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 1 commit into from
Nov 20, 2025
Merged

Add test scaffolding for the remote-test-client #149071

bors merged 1 commit into from
Nov 20, 2025

Conversation

@pvdrz
Copy link
Contributor

@pvdrz pvdrz commented Nov 19, 2025 •
edited
Loading

@rustbot
Copy link
Collaborator

rustbot commented Nov 19, 2025

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Nov 19, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 19, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot assigned jieyouxu and unassigned Mark-Simulacrum Nov 19, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 19, 2025

jieyouxu is not on the review rotation at the moment.
They may take a while to respond.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Enselic
Copy link
Member

Enselic commented Nov 19, 2025

Thank you for creating a separate PR. It's not supposed to go in last however, it is supposed to go in first, and only contain the code needed to allow to run remote-test-client tests. So you only need the src/bootstrap changes in this PR, and possibly a dummy test, although I don't think it will be needed.

If you don't mind, I'd like to double-check: Have you confirmed that the src/bootstrap changes actually runs remote-test-client tests, and that the build fails if a test fails? Thank you in advance for clarifying.

@pvdrz pvdrz force-pushed the pvdrz/remote-test-client-timeout-tests branch from 7fb9e41 to bc39766 Compare November 19, 2025 16:13
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@pvdrz pvdrz force-pushed the pvdrz/remote-test-client-timeout-tests branch from bc39766 to cdd8896 Compare November 19, 2025 17:14
@pvdrz pvdrz changed the title Test the remote-test-client timeout Add test scaffolding for the remote-test-client Nov 19, 2025
@pvdrz pvdrz mentioned this pull request Nov 19, 2025
Merged
@pvdrz
Copy link
Contributor Author

pvdrz commented Nov 19, 2025

@Enselic: yes, the test suite fails if the test is incorrect, I tried it locally.

jieyouxu
jieyouxu approved these changes Nov 20, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

View changes since this review

@jieyouxu
Copy link
Member

jieyouxu commented Nov 20, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 20, 2025

📌 Commit cdd8896 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 20, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 20, 2025
@Zalathar
Rollup merge of rust-lang#149071 - ferrocene:pvdrz/remote-test-client…
7be8e84 
…-timeout-tests, r=jieyouxu

Add test scaffolding for the `remote-test-client`

r? `@jieyouxu`
@Zalathar Zalathar mentioned this pull request Nov 20, 2025
Closed
bors added a commit that referenced this pull request Nov 20, 2025
@bors
Auto merge of #149124 - Zalathar:rollup-objfz6n, r=Zalathar
65a3c1a 
Rollup of 10 pull requests

Successful merges:

 - #146925 (Add doc for va_list APIs)
 - #147035 (alloc: fix `Debug` implementation of `ExtractIf`)
 - #147173 (Add support for hexagon-unknown-qurt target)
 - #148261 (rustc_public: Make Id types !Send / !Sync)
 - #148831 (Bump compiler dependencies)
 - #149041 (ignore unsized types in mips64 and sparc64 callconvs)
 - #149056 (fix the fragment_in_dst_padding_gets_overwritten test on s390x)
 - #149071 (Add test scaffolding for the `remote-test-client`)
 - #149095 (rustc-dev-guide subtree update)
 - #149108 ([AIX][ppc64le-linux-gnu] Add Amy Kwan to target maintainers)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 20, 2025
Merged
bors added a commit that referenced this pull request Nov 20, 2025
@bors
Auto merge of #149132 - matthiaskrgr:rollup-8khp9s2, r=matthiaskrgr
7281a3b 
Rollup of 9 pull requests

Successful merges:

 - #146925 (Add doc for va_list APIs)
 - #147035 (alloc: fix `Debug` implementation of `ExtractIf`)
 - #147173 (Add support for hexagon-unknown-qurt target)
 - #148261 (rustc_public: Make Id types !Send / !Sync)
 - #149041 (ignore unsized types in mips64 and sparc64 callconvs)
 - #149056 (fix the fragment_in_dst_padding_gets_overwritten test on s390x)
 - #149071 (Add test scaffolding for the `remote-test-client`)
 - #149095 (rustc-dev-guide subtree update)
 - #149108 ([AIX][ppc64le-linux-gnu] Add Amy Kwan to target maintainers)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 37dc26c into rust-lang:main Nov 20, 2025
11 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 20, 2025
rust-timer added a commit that referenced this pull request Nov 20, 2025
@rust-timer
Unrolled build for #149071
e4b1763 
Rollup merge of #149071 - ferrocene:pvdrz/remote-test-client-timeout-tests, r=jieyouxu

Add test scaffolding for the `remote-test-client`

r? ``@jieyouxu``
@tshepang tshepang deleted the pvdrz/remote-test-client-timeout-tests branch November 20, 2025 19:53
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Nov 24, 2025
@bors
Auto merge of #149132 - matthiaskrgr:rollup-8khp9s2, r=matthiaskrgr
b9eb517 
Rollup of 9 pull requests

Successful merges:

 - rust-lang/rust#146925 (Add doc for va_list APIs)
 - rust-lang/rust#147035 (alloc: fix `Debug` implementation of `ExtractIf`)
 - rust-lang/rust#147173 (Add support for hexagon-unknown-qurt target)
 - rust-lang/rust#148261 (rustc_public: Make Id types !Send / !Sync)
 - rust-lang/rust#149041 (ignore unsized types in mips64 and sparc64 callconvs)
 - rust-lang/rust#149056 (fix the fragment_in_dst_padding_gets_overwritten test on s390x)
 - rust-lang/rust#149071 (Add test scaffolding for the `remote-test-client`)
 - rust-lang/rust#149095 (rustc-dev-guide subtree update)
 - rust-lang/rust#149108 ([AIX][ppc64le-linux-gnu] Add Amy Kwan to target maintainers)

r? `@ghost`
`@rustbot` modify labels: rollup
@Zalathar Zalathar mentioned this pull request Nov 26, 2025
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 28, 2025
@matthiaskrgr
Rollup merge of rust-lang#147952 - ferrocene:pvdrz/remote-test-client…
d7a36c1 
…-timeout, r=Enselic

Add a timeout to the `remote-test-client` connection

Currently, the `remote-test-client` doesn't have a timeout when connecting to the `remote-test-server`. This means that running tests using it can hang indefinitely which causes issues when running tests on CI, for example.

This PR now sets a default timeout of 5 minutes, meaning that if, for example, `TEST_DEVICE_ADDR=<IP:PORT> ./x test --target riscv64gc-unknown-linux-gnu tests/ui` is run and the `remote-test-server` is not reachable by the client, the client will panic after the timeout is reached.

Additionally, the `TEST_DEVICE_CONNECT_TIMEOUT` env variable can be used to set up the timeout to any value (in seconds).

This PR also wires up a test step for `remote-test-client`, which didn't previously have tool tests run in CI.

Edit: ~~blocked by rust-lang#149071~~
rust-timer added a commit that referenced this pull request Nov 28, 2025
@rust-timer
Unrolled build for #147952
c141add 
Rollup merge of #147952 - ferrocene:pvdrz/remote-test-client-timeout, r=Enselic

Add a timeout to the `remote-test-client` connection

Currently, the `remote-test-client` doesn't have a timeout when connecting to the `remote-test-server`. This means that running tests using it can hang indefinitely which causes issues when running tests on CI, for example.

This PR now sets a default timeout of 5 minutes, meaning that if, for example, `TEST_DEVICE_ADDR=<IP:PORT> ./x test --target riscv64gc-unknown-linux-gnu tests/ui` is run and the `remote-test-server` is not reachable by the client, the client will panic after the timeout is reached.

Additionally, the `TEST_DEVICE_CONNECT_TIMEOUT` env variable can be used to set up the timeout to any value (in seconds).

This PR also wires up a test step for `remote-test-client`, which didn't previously have tool tests run in CI.

Edit: ~~blocked by #149071~~
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Nov 29, 2025
@matthiaskrgr
Rollup merge of #147952 - ferrocene:pvdrz/remote-test-client-timeout,…
821da9e 
… r=Enselic

Add a timeout to the `remote-test-client` connection

Currently, the `remote-test-client` doesn't have a timeout when connecting to the `remote-test-server`. This means that running tests using it can hang indefinitely which causes issues when running tests on CI, for example.

This PR now sets a default timeout of 5 minutes, meaning that if, for example, `TEST_DEVICE_ADDR=<IP:PORT> ./x test --target riscv64gc-unknown-linux-gnu tests/ui` is run and the `remote-test-server` is not reachable by the client, the client will panic after the timeout is reached.

Additionally, the `TEST_DEVICE_CONNECT_TIMEOUT` env variable can be used to set up the timeout to any value (in seconds).

This PR also wires up a test step for `remote-test-client`, which didn't previously have tool tests run in CI.

Edit: ~~blocked by rust-lang/rust#149071~~
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Dec 1, 2025
@matthiaskrgr
Rollup merge of #147952 - ferrocene:pvdrz/remote-test-client-timeout,…
6f5ac83 
… r=Enselic

Add a timeout to the `remote-test-client` connection

Currently, the `remote-test-client` doesn't have a timeout when connecting to the `remote-test-server`. This means that running tests using it can hang indefinitely which causes issues when running tests on CI, for example.

This PR now sets a default timeout of 5 minutes, meaning that if, for example, `TEST_DEVICE_ADDR=<IP:PORT> ./x test --target riscv64gc-unknown-linux-gnu tests/ui` is run and the `remote-test-server` is not reachable by the client, the client will panic after the timeout is reached.

Additionally, the `TEST_DEVICE_CONNECT_TIMEOUT` env variable can be used to set up the timeout to any value (in seconds).

This PR also wires up a test step for `remote-test-client`, which didn't previously have tool tests run in CI.

Edit: ~~blocked by rust-lang/rust#149071~~
makai410 pushed a commit to makai410/rustc_public that referenced this pull request Dec 10, 2025
@bors
Auto merge of #149132 - matthiaskrgr:rollup-8khp9s2, r=matthiaskrgr
a894374 
Rollup of 9 pull requests

Successful merges:

 - rust-lang/rust#146925 (Add doc for va_list APIs)
 - rust-lang/rust#147035 (alloc: fix `Debug` implementation of `ExtractIf`)
 - rust-lang/rust#147173 (Add support for hexagon-unknown-qurt target)
 - rust-lang/rust#148261 (rustc_public: Make Id types !Send / !Sync)
 - rust-lang/rust#149041 (ignore unsized types in mips64 and sparc64 callconvs)
 - rust-lang/rust#149056 (fix the fragment_in_dst_padding_gets_overwritten test on s390x)
 - rust-lang/rust#149071 (Add test scaffolding for the `remote-test-client`)
 - rust-lang/rust#149095 (rustc-dev-guide subtree update)
 - rust-lang/rust#149108 ([AIX][ppc64le-linux-gnu] Add Amy Kwan to target maintainers)

r? `@ghost`
`@rustbot` modify labels: rollup
makai410 pushed a commit to makai410/rust that referenced this pull request Dec 10, 2025
@matthiaskrgr
Rollup merge of rust-lang#149071 - ferrocene:pvdrz/remote-test-client…
9d9dd0d 
…-timeout-tests, r=jieyouxu

Add test scaffolding for the `remote-test-client`

r? ``@jieyouxu``
makai410 pushed a commit to makai410/rust that referenced this pull request Dec 10, 2025
@bors
Auto merge of rust-lang#149132 - matthiaskrgr:rollup-8khp9s2, r=matth…
335b4ba 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#146925 (Add doc for va_list APIs)
 - rust-lang#147035 (alloc: fix `Debug` implementation of `ExtractIf`)
 - rust-lang#147173 (Add support for hexagon-unknown-qurt target)
 - rust-lang#148261 (rustc_public: Make Id types !Send / !Sync)
 - rust-lang#149041 (ignore unsized types in mips64 and sparc64 callconvs)
 - rust-lang#149056 (fix the fragment_in_dst_padding_gets_overwritten test on s390x)
 - rust-lang#149071 (Add test scaffolding for the `remote-test-client`)
 - rust-lang#149095 (rustc-dev-guide subtree update)
 - rust-lang#149108 ([AIX][ppc64le-linux-gnu] Add Amy Kwan to target maintainers)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels

A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

7 participants

@pvdrz @rustbot @rust-log-analyzer @Enselic @jieyouxu @bors @Mark-Simulacrum