Skip to content

Commit 6f5ac83

Browse files
authored
Rollup merge of #147952 - ferrocene:pvdrz/remote-test-client-timeout, r=Enselic
Add a timeout to the `remote-test-client` connection Currently, the `remote-test-client` doesn't have a timeout when connecting to the `remote-test-server`. This means that running tests using it can hang indefinitely which causes issues when running tests on CI, for example. This PR now sets a default timeout of 5 minutes, meaning that if, for example, `TEST_DEVICE_ADDR=<IP:PORT> ./x test --target riscv64gc-unknown-linux-gnu tests/ui` is run and the `remote-test-server` is not reachable by the client, the client will panic after the timeout is reached. Additionally, the `TEST_DEVICE_CONNECT_TIMEOUT` env variable can be used to set up the timeout to any value (in seconds). This PR also wires up a test step for `remote-test-client`, which didn't previously have tool tests run in CI. Edit: ~~blocked by rust-lang/rust#149071~~
2 parents 771576e + ebc1705 commit 6f5ac83

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

src/tests/running.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -321,6 +321,10 @@ Tests are built on the machine running `x` not on the remote machine.
321321
Tests which fail to build unexpectedly (or `ui` tests producing incorrect build
322322
output) may fail without ever running on the remote machine.
323323

324+
There is a default timeout of 30 minutes in case the `remote-test-server`
325+
cannot be reached by the `x` command. This timeout can be modified by using the
326+
`TEST_DEVICE_CONNECT_TIMEOUT_SECONDS` environment variable.
327+
324328
## Testing on emulators
325329

326330
Some platforms are tested via an emulator for architectures that aren't readily available.

0 commit comments

Comments
 (0)