Don't show warnings from xcrun with -Zverbose-internals #145847

madsmtm · 2025-08-25T12:41:30Z

These kinds of warnings can make our test suite fail spuriously, so if we want them, we'll need a different flag.

This was introduced in #131477. Fixes #145543.

r? apiraino
@bors rollup

These kinds of warnings can make our test suites fail, so if we want them, we'll need a different flag.

rustbot · 2025-08-25T12:41:36Z

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

jieyouxu

Thanks

View changes since this review

jieyouxu · 2025-08-25T12:46:23Z

r? jieyouxu @bors r+ rollup

bors · 2025-08-25T12:46:27Z

📌 Commit d262463 has been approved by jieyouxu

It is now in the queue for this repository.

rust-log-analyzer · 2025-08-25T13:48:56Z

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

npm WARN deprecated [email protected]: Rimraf versions prior to v4 are no longer supported
npm WARN deprecated @humanwhocodes/[email protected]: Use @eslint/config-array instead
npm WARN deprecated @humanwhocodes/[email protected]: Use @eslint/object-schema instead
npm WARN deprecated [email protected]: This version is no longer supported. Please see https://eslint.org/version-support for other options.
npm ERR! code 1
npm ERR! git dep preparation failed
npm ERR! command /node/bin/node /node/lib/node_modules/npm/bin/npm-cli.js install --force --cache=/home/user/.npm --prefer-offline=false --prefer-online=false --offline=false --no-progress --no-save --no-audit --include=dev --include=peer --include=optional --no-package-lock-only --no-dry-run
npm ERR! npm WARN using --force Recommended protections disabled.
npm ERR! npm ERR! code E429
npm ERR! npm ERR! 429 Too Many Requests - GET https://registry.npmjs.org/c8
npm ERR! 
npm ERR! npm ERR! A complete log of this run can be found in: /home/user/.npm/_logs/2025-08-25T13_42_52_187Z-debug-0.log

npm ERR! A complete log of this run can be found in: /home/user/.npm/_logs/2025-08-25T13_42_48_628Z-debug-0.log
npm install did not exit successfully

thread 'main' panicked at src/tools/rustdoc-gui-test/src/main.rs:69:10:
unable to install browser-ui-test: Custom { kind: Other, error: "npm install returned exit code exit status: 1" }
stack backtrace:
   0: __rustc::rust_begin_unwind
             at /rustc/788da80fcfcef3f34c90def5baa32813e39a1a41/library/std/src/panicking.rs:697:5
   1: core::panicking::panic_fmt
             at /rustc/788da80fcfcef3f34c90def5baa32813e39a1a41/library/core/src/panicking.rs:75:14

jieyouxu · 2025-08-25T14:54:26Z

npm failure unrelated, separate issue.

madsmtm · 2025-08-25T19:21:35Z

I assume it's spurious, let's try again.

@bors rollup r=jieyouxu

bors · 2025-08-25T19:21:37Z

💡 This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: Enforce in bootstrap that dist and install must have stage at least 1 #145472

bors · 2025-08-25T19:21:38Z

📌 Commit d262463 has been approved by jieyouxu

It is now in the queue for this repository.

Don't show warnings from xcrun with -Zverbose-internals These kinds of warnings can make our test suite fail spuriously, so if we want them, we'll need a different flag. This was introduced in rust-lang#131477. Fixes rust-lang#145543. r? apiraino `@bors` rollup

Rollup of 12 pull requests Successful merges: - #143193 (Port `#[link]` to the new attribute parsing infrastructure ) - #144373 (remove deprecated Error::description in impls) - #144885 (Implement some more checks in `ptr_guaranteed_cmp`. ) - #145535 (make rustdoc::invalid_html_tags more robust) - #145766 (test(rustfmt): Verify frontmatter is preserved) - #145811 (Fix some minor issues in comments) - #145814 (Handle unwinding fatal errors in codegen workers) - #145815 (Wait for DPkg frontend lock when trying to remove packages) - #145821 (compiletest: if a compiler fails, show its output) - #145845 (Make `x test distcheck` self-contained) - #145847 (Don't show warnings from xcrun with -Zverbose-internals) - #145856 (Update books) r? `@ghost` `@rustbot` modify labels: rollup

Don't show warnings from xcrun with -Zverbose-internals These kinds of warnings can make our test suite fail spuriously, so if we want them, we'll need a different flag. This was introduced in rust-lang#131477. Fixes rust-lang#145543. r? apiraino ``@bors`` rollup

Rollup of 13 pull requests Successful merges: - #143193 (Port `#[link]` to the new attribute parsing infrastructure ) - #143689 (Allow linking a prebuilt optimized compiler-rt builtins library) - #144885 (Implement some more checks in `ptr_guaranteed_cmp`. ) - #145535 (make rustdoc::invalid_html_tags more robust) - #145766 (test(rustfmt): Verify frontmatter is preserved) - #145811 (Fix some minor issues in comments) - #145814 (Handle unwinding fatal errors in codegen workers) - #145815 (Wait for DPkg frontend lock when trying to remove packages) - #145821 (compiletest: if a compiler fails, show its output) - #145845 (Make `x test distcheck` self-contained) - #145847 (Don't show warnings from xcrun with -Zverbose-internals) - #145856 (Update books) - #145858 (Update wasm-component-ld dependency) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 12 pull requests Successful merges: - #143689 (Allow linking a prebuilt optimized compiler-rt builtins library) - #144885 (Implement some more checks in `ptr_guaranteed_cmp`. ) - #145535 (make rustdoc::invalid_html_tags more robust) - #145766 (test(rustfmt): Verify frontmatter is preserved) - #145811 (Fix some minor issues in comments) - #145814 (Handle unwinding fatal errors in codegen workers) - #145815 (Wait for DPkg frontend lock when trying to remove packages) - #145821 (compiletest: if a compiler fails, show its output) - #145845 (Make `x test distcheck` self-contained) - #145847 (Don't show warnings from xcrun with -Zverbose-internals) - #145856 (Update books) - #145858 (Update wasm-component-ld dependency) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #145847 - madsmtm:no-xcrun-warnings, r=jieyouxu Don't show warnings from xcrun with -Zverbose-internals These kinds of warnings can make our test suite fail spuriously, so if we want them, we'll need a different flag. This was introduced in #131477. Fixes #145543. r? apiraino ```@bors``` rollup

Don't show warnings from xcrun with -Zverbose-internals

d262463

These kinds of warnings can make our test suites fail, so if we want them, we'll need a different flag.

madsmtm added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. O-apple Operating system: Apple (macOS, iOS, tvOS, visionOS, watchOS) A-linkers Area: linkers... you gotta love linkers labels Aug 25, 2025

rustbot assigned apiraino Aug 25, 2025

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 25, 2025

madsmtm mentioned this pull request Aug 25, 2025

Add -Awarnings on tests for ignoring warning from xcrun #145570

Closed

jieyouxu approved these changes Aug 25, 2025

View reviewed changes

rustbot assigned jieyouxu Aug 25, 2025

rustbot unassigned apiraino Aug 25, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 25, 2025

jieyouxu mentioned this pull request Aug 25, 2025

npm 429 Too Many Requests on browser-ui-test #145850

Open

madsmtm closed this Aug 25, 2025

madsmtm reopened this Aug 25, 2025

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 25, 2025

madsmtm removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 25, 2025

jhpratt mentioned this pull request Aug 25, 2025

Rollup of 12 pull requests #145860

Closed

Zalathar mentioned this pull request Aug 26, 2025

Rollup of 13 pull requests #145865

Closed

Zalathar mentioned this pull request Aug 26, 2025

Rollup of 12 pull requests #145871

Merged

bors merged commit 820bb7f into rust-lang:master Aug 26, 2025
18 of 20 checks passed

rustbot added this to the 1.91.0 milestone Aug 26, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Don't show warnings from xcrun with -Zverbose-internals #145847

Don't show warnings from xcrun with -Zverbose-internals #145847

madsmtm commented Aug 25, 2025 •

edited

Loading

Uh oh!

rustbot commented Aug 25, 2025

Uh oh!

jieyouxu left a comment •

edited by rustbot

Loading

Uh oh!

jieyouxu commented Aug 25, 2025

Uh oh!

bors commented Aug 25, 2025

Uh oh!

rust-log-analyzer commented Aug 25, 2025

Uh oh!

jieyouxu commented Aug 25, 2025

Uh oh!

madsmtm commented Aug 25, 2025

Uh oh!

bors commented Aug 25, 2025

Uh oh!

bors commented Aug 25, 2025

Uh oh!

Uh oh!

Uh oh!

Don't show warnings from xcrun with -Zverbose-internals #145847

Don't show warnings from xcrun with -Zverbose-internals #145847

Conversation

madsmtm commented Aug 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Aug 25, 2025

Uh oh!

jieyouxu left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jieyouxu commented Aug 25, 2025

Uh oh!

bors commented Aug 25, 2025

Uh oh!

rust-log-analyzer commented Aug 25, 2025

Uh oh!

jieyouxu commented Aug 25, 2025

Uh oh!

madsmtm commented Aug 25, 2025

Uh oh!

bors commented Aug 25, 2025

Uh oh!

bors commented Aug 25, 2025

Uh oh!

Uh oh!

Uh oh!

madsmtm commented Aug 25, 2025 •

edited

Loading

jieyouxu left a comment •

edited by rustbot

Loading