Skip to content

Conversation

houpo-bob
Copy link
Contributor

Fix some minor issues in comments

@rustbot
Copy link
Collaborator

rustbot commented Aug 24, 2025

r? @jdno

rustbot has assigned @jdno.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Aug 24, 2025
Copy link
Member

@hkBst hkBst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid typo fixes.

View changes since this review

@samueltardieu
Copy link
Member

Letting this in because there is one user-facing typo in the rustc book.

@bors r+ rollup=always

@bors
Copy link
Collaborator

bors commented Aug 25, 2025

📌 Commit 5d41f7c has been approved by samueltardieu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 25, 2025
jhpratt added a commit to jhpratt/rust that referenced this pull request Aug 25, 2025
Fix some minor issues in comments

Fix some minor issues in comments
bors added a commit that referenced this pull request Aug 25, 2025
Rollup of 12 pull requests

Successful merges:

 - #143193 (Port `#[link]` to the new attribute parsing infrastructure )
 - #144373 (remove deprecated Error::description in impls)
 - #144885 (Implement some more checks in `ptr_guaranteed_cmp`. )
 - #145535 (make rustdoc::invalid_html_tags more robust)
 - #145766 (test(rustfmt): Verify frontmatter is preserved)
 - #145811 (Fix some minor issues in comments)
 - #145814 (Handle unwinding fatal errors in codegen workers)
 - #145815 (Wait for DPkg frontend lock when trying to remove packages)
 - #145821 (compiletest: if a compiler fails, show its output)
 - #145845 (Make `x test distcheck` self-contained)
 - #145847 (Don't show warnings from xcrun with -Zverbose-internals)
 - #145856 (Update books)

r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 26, 2025
Fix some minor issues in comments

Fix some minor issues in comments
bors added a commit that referenced this pull request Aug 26, 2025
Rollup of 13 pull requests

Successful merges:

 - #143193 (Port `#[link]` to the new attribute parsing infrastructure )
 - #143689 (Allow linking a prebuilt optimized compiler-rt builtins library)
 - #144885 (Implement some more checks in `ptr_guaranteed_cmp`. )
 - #145535 (make rustdoc::invalid_html_tags more robust)
 - #145766 (test(rustfmt): Verify frontmatter is preserved)
 - #145811 (Fix some minor issues in comments)
 - #145814 (Handle unwinding fatal errors in codegen workers)
 - #145815 (Wait for DPkg frontend lock when trying to remove packages)
 - #145821 (compiletest: if a compiler fails, show its output)
 - #145845 (Make `x test distcheck` self-contained)
 - #145847 (Don't show warnings from xcrun with -Zverbose-internals)
 - #145856 (Update books)
 - #145858 (Update wasm-component-ld dependency)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Aug 26, 2025
Rollup of 12 pull requests

Successful merges:

 - #143689 (Allow linking a prebuilt optimized compiler-rt builtins library)
 - #144885 (Implement some more checks in `ptr_guaranteed_cmp`. )
 - #145535 (make rustdoc::invalid_html_tags more robust)
 - #145766 (test(rustfmt): Verify frontmatter is preserved)
 - #145811 (Fix some minor issues in comments)
 - #145814 (Handle unwinding fatal errors in codegen workers)
 - #145815 (Wait for DPkg frontend lock when trying to remove packages)
 - #145821 (compiletest: if a compiler fails, show its output)
 - #145845 (Make `x test distcheck` self-contained)
 - #145847 (Don't show warnings from xcrun with -Zverbose-internals)
 - #145856 (Update books)
 - #145858 (Update wasm-component-ld dependency)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Aug 26, 2025
Rollup of 12 pull requests

Successful merges:

 - #143689 (Allow linking a prebuilt optimized compiler-rt builtins library)
 - #144885 (Implement some more checks in `ptr_guaranteed_cmp`. )
 - #145535 (make rustdoc::invalid_html_tags more robust)
 - #145766 (test(rustfmt): Verify frontmatter is preserved)
 - #145811 (Fix some minor issues in comments)
 - #145814 (Handle unwinding fatal errors in codegen workers)
 - #145815 (Wait for DPkg frontend lock when trying to remove packages)
 - #145821 (compiletest: if a compiler fails, show its output)
 - #145845 (Make `x test distcheck` self-contained)
 - #145847 (Don't show warnings from xcrun with -Zverbose-internals)
 - #145856 (Update books)
 - #145858 (Update wasm-component-ld dependency)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 67436ea into rust-lang:master Aug 26, 2025
10 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Aug 26, 2025
rust-timer added a commit that referenced this pull request Aug 26, 2025
Rollup merge of #145811 - houpo-bob:master, r=samueltardieu

Fix some minor issues in comments

Fix some minor issues in comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants