Skip to content

Stabilize #![feature(non_null_from_ref)] #140511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2025
Merged

Stabilize #![feature(non_null_from_ref)] #140511

merged 1 commit into from
May 18, 2025
+4 −3

Conversation

mathisbot
Copy link
Contributor

This PR stabilizes the following:

impl<T: ?Sized> NonNull<T> {
    pub const fn from_ref(reference: &T) -> NonNull<T>;
    pub const fn from_mut(reference: &mut T) -> NonNull<T>;
}

The feature is tracked in #130823.

@rustbot
Copy link
Collaborator

rustbot commented Apr 30, 2025

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 30, 2025
@mathisbot mathisbot mentioned this pull request Apr 30, 2025
Open
4 tasks
@bjoernager

This comment has been minimized.

Sign in to view
@bjoernager
Copy link
Contributor

bjoernager commented Apr 30, 2025 •
edited
Loading

@rustbot label +T-libs-api -T-libs

r? libs-api

@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Apr 30, 2025
@rustbot rustbot assigned BurntSushi and unassigned tgross35 Apr 30, 2025
@rustbot rustbot removed the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Apr 30, 2025
@rustbot

This comment has been minimized.

Sign in to view
@rustbot rustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 30, 2025
@rustbot

This comment has been minimized.

Sign in to view
@rustbot rustbot removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. has-merge-commits PR has merge commits, merge with caution. labels Apr 30, 2025
@dtolnay dtolnay assigned dtolnay and unassigned BurntSushi May 6, 2025
@fee1-dead
Copy link
Member

this should be ready for merging now: #130823 (comment)

dtolnay
dtolnay approved these changes May 18, 2025
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dtolnay
Copy link
Member

dtolnay commented May 18, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented May 18, 2025

📌 Commit e83a0a4 has been approved by dtolnay

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 18, 2025
@fmease fmease mentioned this pull request May 18, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 18, 2025
@bors
Auto merge of rust-lang#141216 - fmease:rollup-pa5mvx3, r=fmease
b53e5c9 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#140113 (Add per page TOC in the `rustc` book)
 - rust-lang#140511 (Stabilize `#![feature(non_null_from_ref)]`)
 - rust-lang#140924 (Make some `f32`/`f64` tests also run in const-context)
 - rust-lang#140966 (Remove #![feature(let_chains)] from library and src/librustdoc)
 - rust-lang#141045 ([win][arm64] Remove 'Arm64 Hazard' undocumented MSVC option and instead disable problematic test)
 - rust-lang#141071 (Enable [behind-upstream] triagebot option for rust-lang/rust)
 - rust-lang#141132 (Use `crate::` prefix for root macro suggestions)
 - rust-lang#141139 (Fix Rust for Linux ping group label)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 1585933 into rust-lang:master May 18, 2025
6 checks passed
@rustbot rustbot added this to the 1.89.0 milestone May 18, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 18, 2025
@rust-timer
Unrolled build for rust-lang#140511
600692e 
Rollup merge of rust-lang#140511 - mathisbot:master, r=dtolnay

Stabilize `#![feature(non_null_from_ref)]`

This PR stabilizes the following:
```rust
impl<T: ?Sized> NonNull<T> {
    pub const fn from_ref(reference: &T) -> NonNull<T>;
    pub const fn from_mut(reference: &mut T) -> NonNull<T>;
}
```
The feature is tracked in [rust-lang#130823](rust-lang#130823).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees

@dtolnay dtolnay

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.89.0
Development

Successfully merging this pull request may close these issues.
8 participants
@mathisbot @rustbot @bjoernager @fee1-dead @dtolnay @bors @BurntSushi @tgross35