Rollup of 8 pull requests #141216
Merged
Rollup of 8 pull requests #141216
+449
−165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad disable problematic test
Signed-off-by: xizheyin <[email protected]>
Co-authored-by: Urgau <[email protected]>
Add per page TOC in the `rustc` book This PR adds per page Table of Content (TOC) in the `rustc` book (to be extended in the future to our other books). The goal is to easy the navigation inside the page by providing quick overview of the page content and our position inside that page. That functionality is unfortunately not available natively in `mdbook`, which prompted community members to create [mdBook-pagetoc](https://github.com/JorelAli/mdBook-pagetoc/) (which this PR is heavily inspired by). It's "only" a JS file (to handle the TOC) and a CSS file (to handle the margin, colors, screen size, ...), there is no "post-processor" needed (in mdbook sense).  Live preview at: http://urgau.rf.gd/book r? ```@jieyouxu```
Stabilize `#![feature(non_null_from_ref)]`
This PR stabilizes the following:
```rust
impl<T: ?Sized> NonNull<T> {
pub const fn from_ref(reference: &T) -> NonNull<T>;
pub const fn from_mut(reference: &mut T) -> NonNull<T>;
}
```
The feature is tracked in [rust-lang#130823](rust-lang#130823).
…Simulacrum Make some `f32`/`f64` tests also run in const-context
Remove #![feature(let_chains)] from library and src/librustdoc PR rust-lang#132833 has stabilized the `let_chains` feature. This PR removes the last occurences from the library, the compiler, and librustdoc (also because rust-lang#140887 missed the conditional in one of the crates as it was behind the "rustc" feature). We keep `core` as exercise for the future as updating it is non-trivial (see PR thread).
[win][arm64] Remove 'Arm64 Hazard' undocumented MSVC option and instead disable problematic test PR rust-lang#140758 added the undocumented `/arm64hazardfree` MSVC linker flag to work around a test failure where LLVM generated code that would trip a hazard in an outdated ARM processor. Adding this flag caused issues with LLD, as it doesn't recognize it. Rethinking the issue, using the undocumented flag seems like the incorrect solution: there's no guarantee that the flag won't be removed in the future, or change its meaning. Instead, I've disabled the problematic test for Arm64 Windows and have filed a bug with the MSVC team to have the check removed: <https://developercommunity.microsoft.com/t/Remove-checking-for-and-fixing-Cortex-A/10905134> This PR supersedes rust-lang#140977 r? ```@jieyouxu```
Enable [behind-upstream] triagebot option for rust-lang/rust After testing in [rustc-develop-guide](rust-lang/rustc-dev-guide#2384 (comment)), we can turn on `behind-upstream` here. Doc: https://forge.rust-lang.org/triagebot/behind-upstream.html r? ```@Urgau```
Use `crate::` prefix for root macro suggestions Fixes rust-lang#141082 I've changed the prefix to `crate` directly, since it's compatible across all editions.
Fix Rust for Linux ping group label Noticed in rust-lang#140966 (comment). Seems like a broken label can cause the triagebot ping message to not be issued. See rust-lang/triagebot#1992. ```@rustbot``` label: +A-rust-for-linux
rustbot
added
A-meta
|
@bors r+ rollup=never p=5 |
bors
added
S-waiting-on-bors
|
⌛ Testing commit c7e2e88 with merge b53e5c9db04c89fa15c96f03ae2e0c538b598940... |
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: 7205fc537d In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 7205fc5 (parent) -> b53e5c9 (this PR) Test differencesShow 120 test diffsStage 0
Stage 1
Stage 2
Additionally, 86 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard b53e5c9db04c89fa15c96f03ae2e0c538b598940 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (b53e5c9): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary 6.4%, secondary 1.4%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (secondary 1.0%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 777.426s -> 776.543s (-0.11%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
rustcbook #140113 (Add per page TOC in therustcbook)#![feature(non_null_from_ref)]#140511 (Stabilize#![feature(non_null_from_ref)])f32/f64tests also run in const-context #140924 (Make somef32/f64tests also run in const-context)crate::prefix for root macro suggestions #141132 (Usecrate::prefix for root macro suggestions)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup