Skip to content

Add T-compiler backports Zulip notifications #140397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+35 −12
Open

Add T-compiler backports Zulip notifications #140397

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 35 additions & 12 deletions triagebot.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -606,9 +606,6 @@ message_on_remove = "Issue #{number}'s prioritization request has been removed."
message_on_close = "Issue #{number} has been closed while requested for prioritization."
message_on_reopen = "Issue #{number} has been reopened."

# FIXME: Patch triagebot to support `notify-zulip.<label>` getting mapped to an array of actions.
# At the moment, the beta-nominated+T-rustdoc action fully occupies the beta-nominated slot
# preventing others from adding more beta-nominated actions.
[notify-zulip."beta-nominated"]
required_labels = ["T-rustdoc"]
zulip_stream = 266220 # #t-rustdoc
Expand All @@ -630,9 +627,6 @@ message_on_remove = "PR #{number}'s beta-nomination has been removed."
message_on_close = "PR #{number} has been closed. Thanks for participating!"
message_on_reopen = "PR #{number} has been reopened. Pinging @*T-rustdoc*."

# FIXME: Patch triagebot to support `notify-zulip.<label>` getting mapped to an array of actions.
# At the moment, the beta-accepted+T-rustdoc action fully occupies the beta-accepted slot
# preventing others from adding more beta-accepted actions.
[notify-zulip."beta-accepted"]
required_labels = ["T-rustdoc"]
zulip_stream = 266220 # #t-rustdoc
Expand All @@ -643,9 +637,6 @@ message_on_remove = "PR #{number}'s beta-acceptance has been **removed**."
message_on_close = "PR #{number} has been closed. Thanks for participating!"
message_on_reopen = "PR #{number} has been reopened. Pinging @*T-rustdoc*."

# FIXME: Patch triagebot to support `notify-zulip.<label>` getting mapped to an array of actions.
# At the moment, the stable-nominated+T-rustdoc action fully occupies the stable-nominated slot
# preventing others from adding more stable-nominated actions.
[notify-zulip."stable-nominated"]
required_labels = ["T-rustdoc"]
zulip_stream = 266220 # #t-rustdoc
Expand All @@ -668,9 +659,6 @@ message_on_remove = "PR #{number}'s stable-nomination has been removed."
message_on_close = "PR #{number} has been closed. Thanks for participating!"
message_on_reopen = "PR #{number} has been reopened. Pinging @*T-rustdoc*."

# FIXME: Patch triagebot to support `notify-zulip.<label>` getting mapped to an array of actions.
# At the moment, the stable-accepted+T-rustdoc action fully occupies the stable-accepted slot
# preventing others from adding more stable-accepted actions.
[notify-zulip."stable-accepted"]
required_labels = ["T-rustdoc"]
zulip_stream = 266220 # #t-rustdoc
Expand All @@ -691,6 +679,41 @@ message_on_remove = "Issue #{number}'s nomination has been removed. Thanks all f
message_on_close = "Issue #{number} has been closed. Thanks for participating!"
message_on_reopen = "Issue #{number} has been reopened. Pinging @*T-types*."

[notify-zulip."beta-nominated".compiler]
Copy link
Member

@fmease fmease May 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this isn't the best location to report this (but I just remembered and will be afk soon), IIRC message_on_add doesn't trigger if the PR author has already added {beta,stable}-nominated before actually opening/submitting the PR (I'm presuming, from the perspective of triagebot, the event is likely "IssueOpened" or whatever, not "LabelsModified" and it's currently only looking for the latter for that).

I first noticed this here: #137899. I know it's hard to tell but I had to remove and readd the label as you can see here #137899 (comment) for it to truly trigger on Zulip. Well, you'd need to compare time & date to verify.

Once I'm back home again, I'll open a triagebot issue or even PR. Edit: I guess it applies to a lot of things, so there's likely an issue for that already.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @fmease for the head-up. if you don't get around to sending a patch, let me know. I can try to do that (and maybe ask you to review)

required_labels = ["T-compiler"]
zulip_stream = 474880 # #t-compiler/backports
topic = "#{number}: beta-nominated"
message_on_add = [
"""\
@**channel** PR #{number} "{title}" has been nominated for beta backport.
""",
"""\
/poll Approve beta backport of #{number}?
approve
decline
don't know
""",
]
message_on_remove = "PR #{number}'s beta-nomination has been removed."

[notify-zulip."stable-nominated".compiler]
required_labels = ["T-compiler"]
zulip_stream = 474880 # #t-compiler/backports
topic = "#{number}: stable-nominated"
message_on_add = [
"""\
@**channel** PR #{number} "{title}" has been nominated for stable backport.
""",
"""\
/poll Approve stable backport of #{number}?
approve
approve (but does not justify new dot release on its own)
decline
don't know
""",
]
message_on_remove = "PR #{number}'s stable-nomination has been removed."

[notify-zulip."A-edition-2021"]
required_labels = ["C-bug"]
zulip_stream = 268952 # #edition
Expand Down
Loading