Add T-compiler backports Zulip notifications #140397
Conversation
rustbot
added
A-meta
|
|
There was a problem hiding this comment.
I know this isn't strictly related but could you remove those four FIXMEs attached to the T-rustdoc+{stable,beta}-{nominated,accepted} handlers now that they've been fixed by rust-lang/triagebot#1853?
Otherwise you or I can send a separate PR. Edit: Eh, let's do that.
apiraino
force-pushed
the
t-compiler-backports-zulip-notifications
branch
from
170a129 to
b5e9db1
Compare
jieyouxu
added
the
T-compiler
apiraino
force-pushed
the
t-compiler-backports-zulip-notifications
branch
from
b5e9db1 to
3f4e535
Compare
| @@ -691,6 +679,41 @@ message_on_remove = "Issue #{number}'s nomination has been removed. Thanks all f | |||
| message_on_close = "Issue #{number} has been closed. Thanks for participating!" | |||
| message_on_reopen = "Issue #{number} has been reopened. Pinging @*T-types*." | |||
|
|
|||
| [notify-zulip."beta-nominated".compiler] | |||
There was a problem hiding this comment.
I know this isn't the best location to report this (but I just remembered and will be afk soon), IIRC message_on_add doesn't trigger if the PR author has already added {beta,stable}-nominated before actually opening/submitting the PR (I'm presuming, from the perspective of triagebot, the event is likely "IssueOpened" or whatever, not "LabelsModified" and it's currently only looking for the latter for that).
I first noticed this here: #137899. I know it's hard to tell but I had to remove and readd the label as you can see here #137899 (comment) for it to truly trigger on Zulip. Well, you'd need to compare time & date to verify.
Once I'm back home again, I'll open a triagebot issue or even PR. Edit: I guess it applies to a lot of things, so there's likely an issue for that already.
There was a problem hiding this comment.
thanks @fmease for the head-up. if you don't get around to sending a patch, let me know. I can try to do that (and maybe ask you to review)
This patch make it so, that the triagebot willl send notifications to the Zulip channel #t-compiler/backports when a label
{stable-beta}-nominatedis added to beta or stable backport pull request. Requirement to trigger this notification is that the pull request be labeledT-compiler.Note: Zulip notifications can send notifications also on other events (
message_on_closeandmessage_on_reopen) but I omitted them for now, I am not yet sure we need them.r? @davidtwco