Subtree update of rust-analyzer
#126865
Merged
Subtree update of rust-analyzer
#126865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`std::env::set_var` will be unsafe in edition 2024, but not before it. I couldn't quite figure out how to check for the span properly, so for now we just turn the false positives into false negatives, which are less bad.
Used for inserting syntax nodes into existing token trees
- Add doc comments to some `Parse` methods - Uses `Parse::new` more
Add path info to `AbsPathBuf::assert`'s assert cc rust-lang/rust-analyzer#17335
…et-cap, r=Veykril fix: Only generate snippets for `extract_expressions_from_format_string` if snippets are supported Part of rust-lang#17332 Fixes `extract_expressions_from_format_string` so that it doesn't generate snippets if the client doesn't support it.
…ykril Add `Function::fn_ptr_type(…)` for obtaining name-erased function type The use case of this function if being able to group functions by their function ptr type. cc `@flodiebold`
…rpolation, r=Veykril style: simplify string interpolation
… r=Veykril Don't mark `#[rustc_deprecated_safe_2024]` functions as unsafe `std::env::set_var` will be unsafe in edition 2024, but not before it. I couldn't quite figure out how to check for the span properly, so for now we just turn the false positives into false negatives, which are less bad.
internal: Improve `find_path` performance cc rust-lang/rust-analyzer#17339, db80216dac3d972612d8e2d12ade3c28a1826ac2 should fix a case where we don't reduce our search space appropriately. This also adds a fuel system which really shouldn't ever be hit, hence why it warns
…r=Veykril Feat: hide double underscored symbols from symbol search Fixes rust-lang#17272 by changing the default behavior of query to skip results that start with `__` (two underscores). Not sure if this has any far reaching implications - a review would help to understand if this is the right place to do the filtering, and if it's fine to do it by default on the query. If you type `__` as your search, then we'll show the matching double unders, just in case you actually need the symbol.
internal: Cleanup some inert attribute stuff
Check that Expr is none before adding fixup Closes rust-lang#17463
internal: Tidy up generics handling in hir-ty a bit
internal: Remove some allocations from hir-ty
fix: use ItemInNs::Macros to convert ModuleItem to ItemInNs fix rust-lang#17425. When converting `PathResolution` to `ItemInNs`, we should convert `ModuleDef::Macro` to `ItemInNs::Macros` to ensure that it can be found in `DefMap`.
minor: Remove Changelog: XXX title from Github release notes Fixes rust-lang#16455 Closes rust-lang#17165
|
rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead. cc @rust-lang/rust-analyzer |
rustbot
added
the
S-waiting-on-review
|
@bors r+ p=1 subtree update |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (33422e7): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (secondary -4.9%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 691.47s -> 691.736s (0.04%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @ghost