You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the project that can't be shared publicly rust-analyzer started hanging up all worker threads within find_path_module / calculate_best_path. I assume that it is not actually hanging (as the recursion does look like having appropriate exit conditions everywhere) but instead running into a search tree so wide that with a max depth of 15 (
) we just run into too much work to do depending on the project setup. Lowering that to 5 seemed to somewhat fix the issue in the project somewhat confirming my assumption
The text was updated successfully, but these errors were encountered:
internal: Improve `find_path` performance
cc #17339, db80216 should fix a case where we don't reduce our search space appropriately. This also adds a fuel system which really shouldn't ever be hit, hence why it warns
lnicola
pushed a commit
to lnicola/rust
that referenced
this issue
Jun 23, 2024
internal: Improve `find_path` performance
cc rust-lang/rust-analyzer#17339, db80216dac3d972612d8e2d12ade3c28a1826ac2 should fix a case where we don't reduce our search space appropriately. This also adds a fuel system which really shouldn't ever be hit, hence why it warns
In the project that can't be shared publicly rust-analyzer started hanging up all worker threads within
find_path_module
/calculate_best_path
. I assume that it is not actually hanging (as the recursion does look like having appropriate exit conditions everywhere) but instead running into a search tree so wide that with a max depth of 15 (rust-analyzer/crates/hir-def/src/find_path.rs
Line 48 in cdb4f96
The text was updated successfully, but these errors were encountered: