Skip to content

Rename std::borrow #11814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brson opened this issue Jan 26, 2014 · 6 comments · Fixed by #11895
Closed

Rename std::borrow #11814

brson opened this issue Jan 26, 2014 · 6 comments · Fixed by #11895
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Milestone
1.0

Comments

@brson
Copy link
Contributor

brson commented Jan 26, 2014

We don't call these 'borrowed pointers' anymore, but 'references'. Maybe std::ref. Nominating.
@huonw
Copy link
Member

huonw commented Jan 26, 2014

ref is a keyword and so doesn't work as a module name.

@glaebhoerl
Copy link
Contributor

reference? :)

@omasanori
Copy link
Contributor

BTW is the word 'region pointers' also obsoleted?

@xales xales mentioned this issue Jan 29, 2014
Merged
@brson
Copy link
Contributor Author

brson commented Jan 29, 2014

@omasanori yes, i think references and lifetimes are preferred to both borrowed pointers and regions.

@omasanori
Copy link
Contributor

@brson Thank you.

@pnkfelix
Copy link
Member

Accepted for 1.0, P-backcompat-libs

bors added a commit that referenced this issue Jan 30, 2014
@bors
auto merge of #11895 : xales/rust/libstd, r=alexcrichton
b3003e1 
Fixes #11814
@bors bors closed this as completed in d7f97e3 Jan 30, 2014
flip1995 pushed a commit to flip1995/rust that referenced this issue Dec 16, 2023
@bors
Auto merge of rust-lang#11853 - J-ZhengLi:issue11814, r=llogiq
75bdbfc 
expending lint [`blocks_in_if_conditions`] to check match expr as well

closes: rust-lang#11814

changelog: rename lint `blocks_in_if_conditions` to [`blocks_in_conditions`] and expand it to check blocks in match scrutinees
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Rename std::borrow to std::reference. xales/rust
5 participants
@brson @omasanori @pnkfelix @huonw @glaebhoerl