Skip to content

Rename std::borrow to std::reference. #11895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 30, 2014
Merged

Rename std::borrow to std::reference. #11895

merged 3 commits into from
Jan 30, 2014

Conversation

xales
Copy link
Contributor

@xales xales commented Jan 29, 2014

Fixes #11814

@xales
Copy link
Contributor Author

xales commented Jan 29, 2014

to_uint and ref_eq are hardly used (about 3 times or so), and are very short. Possibly candidates for removal?

@alexcrichton
Copy link
Member

Interesting! I wonder if this module can just be removed entirely? Either that, or this could become a private module to contain the impls and the functions wouldn't be accessible any more.

I feel like the functions do kinda have questionable utility...

@emberian
Copy link
Member

👍

bors added a commit that referenced this pull request Jan 30, 2014
@bors
auto merge of #11895 : xales/rust/libstd, r=alexcrichton
b3003e1 
Fixes #11814
@bors bors closed this Jan 30, 2014
@bors bors merged commit f17d972 into rust-lang:master Jan 30, 2014
@kvark
Copy link
Contributor

kvark commented Feb 3, 2014

Wow, first you removed Rc::ptr_eq() and advised me to use borrow::ref_eq() instead, and now this one is gone as well. Looks like a sabotage case.

@huonw
Copy link
Member

huonw commented Feb 3, 2014

Just copy the implementation if you really need it; it's one line.

flip1995 pushed a commit to flip1995/rust that referenced this pull request Dec 16, 2023
@bors
Auto merge of rust-lang#11895 - ericwu2003:useless_vec-FP, r=blyxyas
c19508b 
Useless vec false positive

changelog: [`useless_vec`]: fix false positive in macros.

fixes rust-lang#11861

We delay the emission of `useless_vec` lints to the check_crate_post stage, which allows us to effectively undo lints if we find that a `vec![]` expression is being used multiple times after macro expansion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename std::borrow
6 participants
@xales @alexcrichton @emberian @kvark @huonw @bors