Skip to content

fix: Fix false positives for "unnecessary else" diagnostic #16590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 19, 2024
Merged

fix: Fix false positives for "unnecessary else" diagnostic #16590

merged 8 commits into from
Feb 19, 2024

Conversation

@davidsemakula
Copy link
Contributor

@davidsemakula davidsemakula commented Feb 16, 2024 •
edited
Loading

Completes #16567 by @ShoyuVanilla (see #16567 (comment))
Fixes #16556

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 16, 2024
davidsemakula
davidsemakula commented Feb 16, 2024
View reviewed changes
@davidsemakula davidsemakula changed the title fix: False positives for "unnecessary else" diagnostic fix: Fix false positives for "unnecessary else" diagnostic Feb 16, 2024
@davidsemakula davidsemakula mentioned this pull request Feb 16, 2024
Closed
@Veykril Veykril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 19, 2024
@davidsemakula davidsemakula force-pushed the unnecessary-else-diagnostic-fix branch from b1966ef to b2cb061 Compare February 19, 2024 11:56
@Veykril
Copy link
Member

Veykril commented Feb 19, 2024

Thanks!
@bors r+

@bors
Copy link
Contributor

bors commented Feb 19, 2024

📌 Commit b2cb061 has been approved by Veykril

It is now in the queue for this repository.

@Veykril
Copy link
Member

Veykril commented Feb 19, 2024

meh need to rebase again I think
@bors r-

@davidsemakula davidsemakula force-pushed the unnecessary-else-diagnostic-fix branch from b2cb061 to f2218e7 Compare February 19, 2024 12:37
@Veykril
Copy link
Member

Veykril commented Feb 19, 2024

Thanks!
@bors r+

@bors
Copy link
Contributor

bors commented Feb 19, 2024

📌 Commit f2218e7 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Feb 19, 2024

⌛ Testing commit f2218e7 with merge e6b96db...

@bors
Copy link
Contributor

bors commented Feb 19, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing e6b96db to master...

@bors bors merged commit e6b96db into rust-lang:master Feb 19, 2024
@davidsemakula davidsemakula deleted the unnecessary-else-diagnostic-fix branch February 19, 2024 13:01
@ergl ergl mentioned this pull request Feb 21, 2024
Closed
This was referenced May 9, 2024
Closed
Closed
This was referenced May 12, 2024
Closed
Closed
Merged
This was referenced May 28, 2024
Merged
Closed
Closed
Closed
Merged
@philips-software-forest-releaser philips-software-forest-releaser bot mentioned this pull request Jun 4, 2024
Merged
This was referenced Jun 11, 2024
Merged
Merged
@philips-software-forest-releaser philips-software-forest-releaser bot mentioned this pull request Jun 18, 2024
Merged
@philips-software-forest-releaser philips-software-forest-releaser bot mentioned this pull request Jun 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Veykril Veykril Awaiting requested review from Veykril

Assignees

No one assigned

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

remove-unnecessary-else bad suggestions and false positives on thread_local macro

5 participants

@davidsemakula @Veykril @bors @rustbot @ShoyuVanilla