fix: Fix indenting for child if expr with an else branch for "unnecessary else" diagnostic #16575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Contributor
Author
|
Closing because changes have been added to #16567 |
ShoyuVanilla
added a commit
to ShoyuVanilla/rust-analyzer
that referenced
this pull request
Feb 16, 2024
davidsemakula
pushed a commit
to davidsemakula/rust-analyzer
that referenced
this pull request
Feb 19, 2024
davidsemakula
pushed a commit
to davidsemakula/rust-analyzer
that referenced
this pull request
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Indenting for this if-else expression is one level off without this fix.