-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[0.2] Backports #4595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tgross35
wants to merge
8
commits into
rust-lang:libc-0.2
Choose a base branch
from
tgross35:backport-anaheim
base: libc-0.2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[0.2] Backports #4595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable this lint with the expectation that we will eventually be upgrading editions. There are some exceptions needed, and `unsafe_op_in_unsafe_fn` will take a while to go through. (backport <rust-lang#4585>) (cherry picked from commit 2fe8b17)
Add all constants from bionic's `prctl.h` header https://android.googlesource.com/platform/bionic/+/7ac54f5c391bf3aeb9fec84a158939421fd8f505/libc/kernel/uapi/linux/prctl.h (backport <rust-lang#4531>) (cherry picked from commit eb505fb)
Resolve the `improper_ctypes` warning on l4re-uclibc that we are getting in CI. The current version was added in e412497 ("Move L4Re-specific code into separate module.") and doesn't seem to have been intentional. (backport <rust-lang#4584>) (cherry picked from commit 95c1400)
Most of what this crate does is interact with C, so the lint should be useful. It can be disabled on a case-by-case basis as needed. There are a few fixes needed for enums, which will be going away anyway (rust-lang#4419). Additionally, switch the `bad_style` lint to the newer name `nonstandard_style`. (backport <rust-lang#4584>) (cherry picked from commit 38bb46e)
(backport <rust-lang#4578>) (cherry picked from commit 925eb0c)
(backport <rust-lang#4588>) (cherry picked from commit bdc4b7d)
(backport <rust-lang#4460>) (cherry picked from commit e7cf1cc)
|
Resolve an instance of `improper_ctypes`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport the following:
rust_2024_compatibility
lint #4585improper_ctypes
#4584