Skip to content

netbsd: Export ioctl request generator macros #4460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2025
Merged

Conversation

qinghon
Copy link
Contributor

@qinghon qinghon commented May 24, 2025

Description

add ioctl request generator macros for netbsd like

Sources

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see rust-lang/libc#3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

    ci broken in netbsd

@rustbot label +stable-nominated

@rustbot
Copy link
Collaborator

rustbot commented May 24, 2025

Some changes occurred in OpenBSD module

cc @semarie

@rustbot rustbot added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label May 25, 2025
@rustbot
Copy link
Collaborator

rustbot commented May 25, 2025

Some changes occurred in OpenBSD module

cc @semarie

@semarie
Copy link
Contributor

semarie commented May 25, 2025

with IOC_INOUT fixed, the change is fine regarding OpenBSD.

@qinghon qinghon requested a review from semarie May 26, 2025 07:03
@qinghon qinghon requested a review from semarie May 26, 2025 14:47
Copy link
Contributor

@semarie semarie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tgross35 I reviewed both OpenBSD and NetBSD code, and it looks fine.
But I only tested it on OpenBSD.

Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this took so long for me to get to, LGTM as well

@tgross35 tgross35 enabled auto-merge July 28, 2025 08:30
auto-merge was automatically disabled July 28, 2025 15:44

Head branch was pushed to by a user without write access

@qinghon
Copy link
Contributor Author

qinghon commented Jul 28, 2025

@tgross35
The PR has been open too long and the code style has drifted. I've fixed it, but now it requires a manual merge.

@tgross35
Copy link
Contributor

I didn't realize how much back and forth this history had; there shouldn't "fix bug" commits if they fix bugs introduced in this PR. Please squash, and rebase to drop the merge commit.

@qinghon
Copy link
Contributor Author

qinghon commented Jul 29, 2025

@tgross35 thanks for you review

Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@tgross35 tgross35 added this pull request to the merge queue Jul 29, 2025
Merged via the queue into rust-lang:main with commit e7cf1cc Jul 29, 2025
48 of 52 checks passed
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Jul 29, 2025
@tgross35 tgross35 mentioned this pull request Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-unix stable-nominated This PR should be considered for cherry-pick to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants