-
Notifications
You must be signed in to change notification settings - Fork 1.1k
netbsd: Export ioctl request generator macros #4460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Some changes occurred in OpenBSD module cc @semarie |
Some changes occurred in OpenBSD module cc @semarie |
with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@tgross35 I reviewed both OpenBSD and NetBSD code, and it looks fine.
But I only tested it on OpenBSD.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry this took so long for me to get to, LGTM as well
Head branch was pushed to by a user without write access
@tgross35 |
I didn't realize how much back and forth this history had; there shouldn't "fix bug" commits if they fix bugs introduced in this PR. Please squash, and rebase to drop the merge commit. |
@tgross35 thanks for you review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you!
(backport <rust-lang#4460>) (cherry picked from commit e7cf1cc)
Description
add ioctl request generator macros for netbsd like
Sources
Checklist
libc-test/semver
have been updated*LAST
or*MAX
areincluded (see rust-lang/libc#3131)
cd libc-test && cargo test --target mytarget
);especially relevant for platforms that may not be checked in CI
@rustbot label +stable-nominated