Remove daemonization code from docs.rs #844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great to me, the |
jyn514
reviewed
Jun 21, 2020
This commit removes the forking code in the docs.rs daemon, forcing it to always run in the background. The rationale for the change is that forking adds complexity and sets extra constraint for development, while it's not needed anymore on modern infrastructure. The --foreground flag is kept in the binary for compatibility, and it will only print a warning. Once this commit is deployed in production for a while, the flag can be removed.
pietroalbini
force-pushed
the
always-foreground
branch
from
9db0c5b to
f227ce4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the forking code in the docs.rs daemon, forcing it to always run in the background. The rationale for the change is that forking adds complexity and sets extra constraint for development, while it's not needed anymore on modern infrastructure.
The --foreground flag is kept in the binary for compatibility, and it will only print a warning. Once this PR is deployed in production for a while, the flag can be removed.
r? @jyn514