remove daemonization code from docs.rs

This commit removes the forking code in the docs.rs daemon, forcing it
to always run in the background. The rationale for the change is that
forking adds complexity and sets extra constraint for development, while
it's not needed anymore on modern infrastructure.

The --foreground flag is kept in the binary for compatibility, and it
will only print a warning. Once this commit is deployed in production
for a while, the flag can be removed.

Author: pietroalbini

Cargo.lock

@@ -67,8 +67,6 @@ chrono = { version = "0.4.11", features = ["serde"] }
 time = "0.1" # TODO: Remove once `iron` is removed
 
 [target.'cfg(not(windows))'.dependencies]
-libc = "0.2"
-
 # Process information
 procfs = "0.7"
 

Cargo.toml

@@ -202,7 +202,7 @@ docker-compose run web database blacklist remove <CRATE_NAME>
 # Run a persistent daemon which queues builds and starts a web server.
 # Warning: This will try to queue hundreds of packages on crates.io, only start it
 # if you have enough resources!
-docker-compose run -p 3000:3000 web daemon --foreground
+docker-compose run -p 3000:3000 web daemon
 ```
 
 ### Changing the build environment

README.md

@@ -62,7 +62,7 @@ enum CommandLine {
 
     /// Starts cratesfyi daemon
     Daemon {
-        /// Run the server in the foreground instead of detaching a child
+        /// Deprecated. Run the server in the foreground instead of detaching a child
         #[structopt(name = "FOREGROUND", short = "f", long = "foreground")]
         foreground: bool,
     },
@@ -93,7 +93,11 @@ impl CommandLine {
                 Server::start(Some(&socket_addr), reload_templates, config)?;
             }
             Self::Daemon { foreground } => {
-                cratesfyi::utils::start_daemon(!foreground, config)?;
+                if foreground {
+                    log::warn!("--foreground was passed, but there is no need for it anymore");
+                }
+
+                cratesfyi::utils::start_daemon(config)?;
             }
             Self::Database { subcommand } => subcommand.handle_args(),
             Self::Queue { subcommand } => subcommand.handle_args(),

src/bin/cratesfyi.rs

@@ -16,10 +16,7 @@ use std::sync::Arc;
 use std::time::Duration;
 use std::{env, thread};
 
-#[cfg(not(target_os = "windows"))]
-use ::{libc::fork, std::fs::File, std::io::Write, std::process::exit};
-
-pub fn start_daemon(background: bool, config: Arc<Config>) -> Result<(), Error> {
+pub fn start_daemon(config: Arc<Config>) -> Result<(), Error> {
     const CRATE_VARIABLES: [&str; 3] = [
         "CRATESFYI_PREFIX",
         "CRATESFYI_GITHUB_USERNAME",
@@ -38,31 +35,6 @@ pub fn start_daemon(background: bool, config: Arc<Config>) -> Result<(), Error>
     // check paths once
     dbopts.check_paths().unwrap();
 
-    if background {
-        #[cfg(target_os = "windows")]
-        {
-            panic!("running in background not supported on windows");
-        }
-
-        #[cfg(not(target_os = "windows"))]
-        {
-            // fork the process
-            let pid = unsafe { fork() };
-            if pid > 0 {
-                let mut file = File::create(dbopts.prefix.join("cratesfyi.pid"))
-                    .expect("Failed to create pid file");
-                writeln!(&mut file, "{}", pid).expect("Failed to write pid");
-
-                info!(
-                    "cratesfyi {} daemon started on: {}",
-                    crate::BUILD_VERSION,
-                    pid
-                );
-                exit(0);
-            }
-        }
-    }
-
     // check new crates every minute
     thread::Builder::new()
         .name("registry index reader".to_string())