Cleanup crate version downloads processing code #2977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JS has no `DateWithoutTime` class, and using `Date` makes it unnecessarily complicated here, so we'll just keep it as a string and do the conversion only when needed.
This was only needed when the `date` attribute was still a `Date`, but now we can just use the strings directly
|
Thanks, that tidies it up nicely! @bors r+ |
|
📌 Commit 2d85521 has been approved by |
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets rid of a few instances of unnecessary
Dateparsing. In most cases we can just use the ISO8601 string directly, without having to convert toDateand back to a string all the time.r? @locks