Auto merge of #2977 - Turbo87:downloads-cleanup, r=locks

Cleanup crate version downloads processing code

This gets rid of a few instances of unnecessary `Date` parsing. In most cases we can just use the ISO8601 string directly, without having to convert to `Date` and back to a string all the time.

r? `@locks`

Author: bors

app/controllers/crate/version.js

@@ -55,20 +55,20 @@ export default class CrateVersionController extends Controller {
     let versions = [];
     for (let i = 0; i < 90; i++) {
       let now = moment().subtract(i, 'days');
-      dates[now.format('MMM D')] = { date: now, cnt: {} };
+      dates[now.toISOString().slice(0, 10)] = { date: now, cnt: {} };
     }
 
     downloads.forEach(d => {
-      let version_id = d.get('version.id');
-      let key = moment(d.get('date')).utc().format('MMM D');
+      let version_id = d.version.id;
+      let key = d.date;
       if (dates[key]) {
         let prev = dates[key].cnt[version_id] || 0;
-        dates[key].cnt[version_id] = prev + d.get('downloads');
+        dates[key].cnt[version_id] = prev + d.downloads;
       }
     });
 
     extra.forEach(d => {
-      let key = moment(d.date).utc().format('MMM D');
+      let key = d.date;
       if (dates[key]) {
         let prev = dates[key].cnt[null] || 0;
         dates[key].cnt[null] = prev + d.downloads;

app/models/version-download.js

@@ -1,8 +1,10 @@
 import Model, { belongsTo, attr } from '@ember-data/model';
 
 export default class VersionDownload extends Model {
+  /** @type number */
   @attr downloads;
-  @attr('date') date;
+  /** @type string */
+  @attr date;
 
   @belongsTo('version', { async: false }) version;
 }