Skip to content

Conversation

hydra
Copy link

@hydra hydra commented Sep 21, 2021

This PR has two commits.

  1. one to bump the versions to the latest patch-level.
  2. to allow latest patch release of a dependency - this reduces maintenance of this repo when the dependencies release a new version.

See also:

@hydra hydra requested a review from a team as a code owner September 21, 2021 12:26
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @thalesfragoso (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-cortex-m labels Sep 21, 2021
@adamgreig
Copy link
Member

Thanks for this PR!

In Cargo, the caret is the default operator if none are specified, so there's no need to add an explicit caret. Consequently, there's also no need to update dependency versions unless we need to use a new feature only introduced in that version -- any downstream users will automatically use whichever compatible version their binary crate wants, even if it's a newer patch release, due to the implicit caret.

Since we're not using any new features from these dependencies, is there any other reason to prevent users using an older compatible version?

@hydra
Copy link
Author

hydra commented Sep 21, 2021

In Cargo, the caret is the default operator if none are specified, so there's no need to add an explicit caret.

ahh ok, I missed the 'default operator' bit in the docs, thanks for pointing that out.

Consequently, there's also no need to update dependency versions unless we need to use a new feature only introduced in that version -- any downstream users will automatically use whichever compatible version their binary crate wants, even if it's a newer patch release, due to the implicit caret.

Since we're not using any new features from these dependencies, is there any other reason to prevent users using an older compatible version?

No, I'll close this PR then, That was easy! 😄

@hydra hydra closed this Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-cortex-m
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants