-
Notifications
You must be signed in to change notification settings - Fork 173
Update bare-metal dependency #350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Bare-metal has released its 1.0 version. Let's use it!
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @adamgreig (or someone else) soon. Please see the contribution instructions for more information. |
Okay... I see. |
Thanks for the PR! You're right that this will need to go into cortex-m 0.8 due to being a breaking change, but I don't think there's any reason to do that soon - we don't have any other breaking changes queued up for cortex-m at the moment, and there's no new features granted by using bare-metal 1.0 or removing this impl except for breaking a bunch of the ecosystem that's still migrating to the newer Once we have a few more breaking changes or large new features queued up for cortex-m 0.8, we'll definitely include this PR in it, and possibly get rid of bare-metal all together (if we can figure out a better way to handle the Mutex). |
See also #353 which includes a bump of |
Hi again, with regards to this PR being scheduled for 0.8 release, how do you guys plan/prepare for the next release? I note that you have |
The This PR is nominally slated for 0.8, but we're not planning to release 0.8 any time soon -- we specifically want to leave plenty of time for the ecosystem to stop using the old bare_metal, which takes a lot of time to work through. If we end up wanting to release 0.8 sooner, this PR might even wait until after that, since all it does in effect is remove Nevertheless you're right in general, it would be nice to have more managed branches for release management. We don't really have a wg-wide strategy at the moment beyond a fairly ad-hoc use of branches to manage patch releases to older minor versions. |
RTIC is using bare-metal v1 for their upcoming 0.6 release (currently on 0.6.0-rc2). Might be a good idea to make this change around the same time to maintain compatibility for critical section tokens. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Master branch is already now for 0.8 development (since it has some breaking changes from 0.7), so let's get this merged too. Thanks again and sorry for the wait!
bors merge
Merge conflict. |
bors merge |
Build succeeded! And happy new year! 🎉 |
Bare-metal has released its 1.0 version. Let's use it!