Untangle dependent shared_context #1334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously I mistakenly assumed there's a problem with RSpec 4, as it includes the context that defines metadata first, and when we were removing `:config` from our `with default RSpec/Language`, we had to include `config` one first from `spec_helper.rb`. In reality, if one shared context depends on another, it needs to explicitly include it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously I mistakenly assumed there's a problem with RSpec 4, as it includes the context that defines metadata first, and when we were removing
:configfrom ourwith default RSpec/Language, we had to includeconfigone first fromspec_helper.rb.In reality, if one shared context depends on another, it needs to explicitly include it.
Originated in #1322, follow-up to #1332. Also see rubocop/rubocop@1e77a15#diff-a328b4f030d5897fe22c01bb96a3bfbcc8bcc6a11f936d1e7a2db73a721d0eb8L52
Before submitting the PR make sure the following are checked:
master(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).