Remove the now-redundant include_context #1332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now, when this rubocop/rubocop@1e77a15#diff-a328b4f030d5897fe22c01bb96a3bfbcc8bcc6a11f936d1e7a2db73a721d0eb8L52 has been merged, there's no race condition between included contexts.
3 tasks
pirj
added a commit
that referenced
this pull request
May 6, 2023
Previously, this was needed to have control over "config" shared context inclusion. We wanted to include ours, but not the one from `rubocop`. This is a follow-up to #1332.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #1322
Now, when this
rubocop/rubocop@1e77a15#diff-a328b4f030d5897fe22c01bb96a3bfbcc8bcc6a11f936d1e7a2db73a721d0eb8L52
has been merged, there's no race condition between included contexts.
Before submitting the PR make sure the following are checked:
master(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).