Skip to content

Conversation

@yahonda
Copy link
Collaborator

@yahonda yahonda commented Mar 17, 2022

This commit addresses these two failures against Rails main branch.
https://app.travis-ci.com/github/rsim/ruby-plsql/jobs/563373660

Failures:
  1) DBMS_OUTPUT logging with Activerecord connection should log output to specified stream
     Failure/Error: tdo = raw_oci_connection.get_tdo_by_class(value.class)
     NoMethodError:
       undefined method `get_tdo_by_class' for nil:NilClass
               tdo = raw_oci_connection.get_tdo_by_class(value.class)
                                       ^^^^^^^^^^^^^^^^^
     # ./lib/plsql/oci_connection.rb:263:in `ora_value_to_ruby_value'
     # ./lib/plsql/oci_connection.rb:112:in `[]'
     # ./lib/plsql/procedure_call.rb:602:in `dbms_output_lines'
     # ./lib/plsql/procedure_call.rb:620:in `dbms_output_log'
     # ./lib/plsql/procedure_call.rb:41:in `exec'
     # ./lib/plsql/procedure.rb:546:in `exec'
     # ./lib/plsql/schema.rb:185:in `method_missing'
     # ./spec/plsql/schema_spec.rb:352:in `block (3 levels) in <top (required)>'
  2) DBMS_OUTPUT logging with Activerecord connection should log output after reconnection
     Failure/Error: tdo = raw_oci_connection.get_tdo_by_class(value.class)
     NoMethodError:
       undefined method `get_tdo_by_class' for nil:NilClass
               tdo = raw_oci_connection.get_tdo_by_class(value.class)
                                       ^^^^^^^^^^^^^^^^^
     # ./lib/plsql/oci_connection.rb:263:in `ora_value_to_ruby_value'
     # ./lib/plsql/oci_connection.rb:112:in `[]'
     # ./lib/plsql/procedure_call.rb:602:in `dbms_output_lines'
     # ./lib/plsql/procedure_call.rb:620:in `dbms_output_log'
     # ./lib/plsql/procedure_call.rb:41:in `exec'
     # ./lib/plsql/procedure.rb:546:in `exec'
     # ./lib/plsql/schema.rb:185:in `method_missing'
     # ./spec/plsql/schema_spec.rb:358:in `block (3 levels) in <top (required)>'
Finished in 13.12 seconds (files took 0.35468 seconds to load)
453 examples, 2 failures, 3 pending

Related to rsim/oracle-enhanced#2265
Follow up rails/rails#44530

This commit addresses these two failures against Rails main branch.
https://app.travis-ci.com/github/rsim/ruby-plsql/jobs/563373660

```
Failures:
  1) DBMS_OUTPUT logging with Activerecord connection should log output to specified stream
     Failure/Error: tdo = raw_oci_connection.get_tdo_by_class(value.class)
     NoMethodError:
       undefined method `get_tdo_by_class' for nil:NilClass
               tdo = raw_oci_connection.get_tdo_by_class(value.class)
                                       ^^^^^^^^^^^^^^^^^
     # ./lib/plsql/oci_connection.rb:263:in `ora_value_to_ruby_value'
     # ./lib/plsql/oci_connection.rb:112:in `[]'
     # ./lib/plsql/procedure_call.rb:602:in `dbms_output_lines'
     # ./lib/plsql/procedure_call.rb:620:in `dbms_output_log'
     # ./lib/plsql/procedure_call.rb:41:in `exec'
     # ./lib/plsql/procedure.rb:546:in `exec'
     # ./lib/plsql/schema.rb:185:in `method_missing'
     # ./spec/plsql/schema_spec.rb:352:in `block (3 levels) in <top (required)>'
  2) DBMS_OUTPUT logging with Activerecord connection should log output after reconnection
     Failure/Error: tdo = raw_oci_connection.get_tdo_by_class(value.class)
     NoMethodError:
       undefined method `get_tdo_by_class' for nil:NilClass
               tdo = raw_oci_connection.get_tdo_by_class(value.class)
                                       ^^^^^^^^^^^^^^^^^
     # ./lib/plsql/oci_connection.rb:263:in `ora_value_to_ruby_value'
     # ./lib/plsql/oci_connection.rb:112:in `[]'
     # ./lib/plsql/procedure_call.rb:602:in `dbms_output_lines'
     # ./lib/plsql/procedure_call.rb:620:in `dbms_output_log'
     # ./lib/plsql/procedure_call.rb:41:in `exec'
     # ./lib/plsql/procedure.rb:546:in `exec'
     # ./lib/plsql/schema.rb:185:in `method_missing'
     # ./spec/plsql/schema_spec.rb:358:in `block (3 levels) in <top (required)>'
Finished in 13.12 seconds (files took 0.35468 seconds to load)
453 examples, 2 failures, 3 pending
```

Related to rsim/oracle-enhanced#2265
Follow up rails/rails#44530
@yahonda yahonda merged commit 50a0654 into rsim:master Mar 17, 2022
@yahonda yahonda deleted the diag branch March 17, 2022 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant