Skip to content

Rename the raw connection ivar to @raw_connection #2265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 26, 2022
Merged

Rename the raw connection ivar to @raw_connection #2265

merged 1 commit into from
Feb 26, 2022

Conversation

@koic
Copy link
Collaborator

@koic koic commented Feb 25, 2022

Follow up rails/rails#44530.

@koic koic force-pushed the rename_raw_connection_ivar branch from 7fb630d to 5c51e56 Compare February 25, 2022 17:49
@koic koic force-pushed the rename_raw_connection_ivar branch from 5c51e56 to 8e574d9 Compare February 25, 2022 18:02
@koic
Copy link
Collaborator Author

koic commented Feb 25, 2022

The following CI failure seem to be resolved by merging this PR into master branch.

Run cd guides/bug_report_templates
Fetching https://github.com/rsim/oracle-enhanced.git
Fetching https://github.com/rails/rails.git
Fetching gem metadata from https://rubygems.org/.......
Resolving dependencies...
Using concurrent-ruby 1.1.9
Using minitest 5.15.0
Fetching ruby-oci8 2.2.11
Fetching ruby-plsql 0.8.0
Installing ruby-plsql 0.8.0
Installing ruby-oci8 2.2.11 with native extensions
Using bundler 2.3.8
Using i[18](https://github.com/rsim/oracle-enhanced/runs/5337457268?check_suite_focus=true#step:13:18)n 1.10.0
Using tzinfo 2.0.4
Using activesupport 7.1.0.alpha from https://github.com/rails/rails.git (at main@49299c4)
Using activemodel 7.1.0.alpha from https://github.com/rails/rails.git (at main@49299c4)
Using activerecord 7.1.0.alpha from https://github.com/rails/rails.git (at main@49299c4)
Using activerecord-oracle_enhanced-adapter 7.1.0.alpha from https://github.com/rsim/oracle-enhanced.git (at master@c[26](https://github.com/rsim/oracle-enhanced/runs/5337457268?check_suite_focus=true#step:13:26)f3ec)
/opt/hostedtoolcache/Ruby/3.1.1/x64/lib/ruby/gems/3.1.0/bundler/gems/oracle-enhanced-c26f3ec0a[29](https://github.com/rsim/oracle-enhanced/runs/5337457268?check_suite_focus=true#step:13:29)c/lib/active_record/connection_adapters/oracle_enhanced_adapter.rb:682:in `get_database_version': undefined method `database_version' for nil:NilClass (NoMethodError)

        @connection.database_version
                   ^^^^^^^^^^^^^^^^^
	from /opt/hostedtoolcache/Ruby/3.1.1/x64/lib/ruby/gems/3.1.0/bundler/gems/rails-49299c4f82db/activerecord/lib/active_record/connection_adapters/schema_cache.rb:145:in `database_version'

https://github.com/rsim/oracle-enhanced/runs/5337457268?check_suite_focus=true#step:13:1

@yahonda yahonda merged commit 6ea02b0 into rsim:master Feb 26, 2022
@koic koic deleted the rename_raw_connection_ivar branch February 26, 2022 06:16
yahonda added a commit to yahonda/ruby-plsql that referenced this pull request Mar 17, 2022
@yahonda
Rename the raw connection ivar to @raw_connection
e7f61bb 
This commit addresses these two failures against Rails main branch.
https://app.travis-ci.com/github/rsim/ruby-plsql/jobs/563373660

```
Failures:
  1) DBMS_OUTPUT logging with Activerecord connection should log output to specified stream
     Failure/Error: tdo = raw_oci_connection.get_tdo_by_class(value.class)
     NoMethodError:
       undefined method `get_tdo_by_class' for nil:NilClass
               tdo = raw_oci_connection.get_tdo_by_class(value.class)
                                       ^^^^^^^^^^^^^^^^^
     # ./lib/plsql/oci_connection.rb:263:in `ora_value_to_ruby_value'
     # ./lib/plsql/oci_connection.rb:112:in `[]'
     # ./lib/plsql/procedure_call.rb:602:in `dbms_output_lines'
     # ./lib/plsql/procedure_call.rb:620:in `dbms_output_log'
     # ./lib/plsql/procedure_call.rb:41:in `exec'
     # ./lib/plsql/procedure.rb:546:in `exec'
     # ./lib/plsql/schema.rb:185:in `method_missing'
     # ./spec/plsql/schema_spec.rb:352:in `block (3 levels) in <top (required)>'
  2) DBMS_OUTPUT logging with Activerecord connection should log output after reconnection
     Failure/Error: tdo = raw_oci_connection.get_tdo_by_class(value.class)
     NoMethodError:
       undefined method `get_tdo_by_class' for nil:NilClass
               tdo = raw_oci_connection.get_tdo_by_class(value.class)
                                       ^^^^^^^^^^^^^^^^^
     # ./lib/plsql/oci_connection.rb:263:in `ora_value_to_ruby_value'
     # ./lib/plsql/oci_connection.rb:112:in `[]'
     # ./lib/plsql/procedure_call.rb:602:in `dbms_output_lines'
     # ./lib/plsql/procedure_call.rb:620:in `dbms_output_log'
     # ./lib/plsql/procedure_call.rb:41:in `exec'
     # ./lib/plsql/procedure.rb:546:in `exec'
     # ./lib/plsql/schema.rb:185:in `method_missing'
     # ./spec/plsql/schema_spec.rb:358:in `block (3 levels) in <top (required)>'
Finished in 13.12 seconds (files took 0.35468 seconds to load)
453 examples, 2 failures, 3 pending
```

Related to rsim/oracle-enhanced#2265
Follow up rails/rails#44530
@yahonda yahonda mentioned this pull request Mar 17, 2022
Merged
yahonda added a commit to yahonda/ruby-plsql that referenced this pull request Mar 17, 2022
@yahonda
Rename the raw connection ivar to @raw_connection
b0ac0e3 
This commit addresses these two failures against Rails main branch.
https://app.travis-ci.com/github/rsim/ruby-plsql/jobs/563373660

```
Failures:
  1) DBMS_OUTPUT logging with Activerecord connection should log output to specified stream
     Failure/Error: tdo = raw_oci_connection.get_tdo_by_class(value.class)
     NoMethodError:
       undefined method `get_tdo_by_class' for nil:NilClass
               tdo = raw_oci_connection.get_tdo_by_class(value.class)
                                       ^^^^^^^^^^^^^^^^^
     # ./lib/plsql/oci_connection.rb:263:in `ora_value_to_ruby_value'
     # ./lib/plsql/oci_connection.rb:112:in `[]'
     # ./lib/plsql/procedure_call.rb:602:in `dbms_output_lines'
     # ./lib/plsql/procedure_call.rb:620:in `dbms_output_log'
     # ./lib/plsql/procedure_call.rb:41:in `exec'
     # ./lib/plsql/procedure.rb:546:in `exec'
     # ./lib/plsql/schema.rb:185:in `method_missing'
     # ./spec/plsql/schema_spec.rb:352:in `block (3 levels) in <top (required)>'
  2) DBMS_OUTPUT logging with Activerecord connection should log output after reconnection
     Failure/Error: tdo = raw_oci_connection.get_tdo_by_class(value.class)
     NoMethodError:
       undefined method `get_tdo_by_class' for nil:NilClass
               tdo = raw_oci_connection.get_tdo_by_class(value.class)
                                       ^^^^^^^^^^^^^^^^^
     # ./lib/plsql/oci_connection.rb:263:in `ora_value_to_ruby_value'
     # ./lib/plsql/oci_connection.rb:112:in `[]'
     # ./lib/plsql/procedure_call.rb:602:in `dbms_output_lines'
     # ./lib/plsql/procedure_call.rb:620:in `dbms_output_log'
     # ./lib/plsql/procedure_call.rb:41:in `exec'
     # ./lib/plsql/procedure.rb:546:in `exec'
     # ./lib/plsql/schema.rb:185:in `method_missing'
     # ./spec/plsql/schema_spec.rb:358:in `block (3 levels) in <top (required)>'
Finished in 13.12 seconds (files took 0.35468 seconds to load)
453 examples, 2 failures, 3 pending
```

Related to rsim/oracle-enhanced#2265
Follow up rails/rails#44530
yahonda added a commit to yahonda/ruby-plsql that referenced this pull request Mar 17, 2022
@yahonda
Rename the raw connection ivar to @raw_connection
f492ea5 
This commit addresses these two failures against Rails main branch.
https://app.travis-ci.com/github/rsim/ruby-plsql/jobs/563373660

```
Failures:
  1) DBMS_OUTPUT logging with Activerecord connection should log output to specified stream
     Failure/Error: tdo = raw_oci_connection.get_tdo_by_class(value.class)
     NoMethodError:
       undefined method `get_tdo_by_class' for nil:NilClass
               tdo = raw_oci_connection.get_tdo_by_class(value.class)
                                       ^^^^^^^^^^^^^^^^^
     # ./lib/plsql/oci_connection.rb:263:in `ora_value_to_ruby_value'
     # ./lib/plsql/oci_connection.rb:112:in `[]'
     # ./lib/plsql/procedure_call.rb:602:in `dbms_output_lines'
     # ./lib/plsql/procedure_call.rb:620:in `dbms_output_log'
     # ./lib/plsql/procedure_call.rb:41:in `exec'
     # ./lib/plsql/procedure.rb:546:in `exec'
     # ./lib/plsql/schema.rb:185:in `method_missing'
     # ./spec/plsql/schema_spec.rb:352:in `block (3 levels) in <top (required)>'
  2) DBMS_OUTPUT logging with Activerecord connection should log output after reconnection
     Failure/Error: tdo = raw_oci_connection.get_tdo_by_class(value.class)
     NoMethodError:
       undefined method `get_tdo_by_class' for nil:NilClass
               tdo = raw_oci_connection.get_tdo_by_class(value.class)
                                       ^^^^^^^^^^^^^^^^^
     # ./lib/plsql/oci_connection.rb:263:in `ora_value_to_ruby_value'
     # ./lib/plsql/oci_connection.rb:112:in `[]'
     # ./lib/plsql/procedure_call.rb:602:in `dbms_output_lines'
     # ./lib/plsql/procedure_call.rb:620:in `dbms_output_log'
     # ./lib/plsql/procedure_call.rb:41:in `exec'
     # ./lib/plsql/procedure.rb:546:in `exec'
     # ./lib/plsql/schema.rb:185:in `method_missing'
     # ./spec/plsql/schema_spec.rb:358:in `block (3 levels) in <top (required)>'
Finished in 13.12 seconds (files took 0.35468 seconds to load)
453 examples, 2 failures, 3 pending
```

Related to rsim/oracle-enhanced#2265
Follow up rails/rails#44530
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@koic @yahonda