Skip to content

Conversation

@yahonda
Copy link
Collaborator

@yahonda yahonda commented Dec 10, 2020

This pull request removes visit_Arel_Nodes_NotIn and visit_Arel_Nodes_In visitors to use visit_Arel_Nodes_HomogeneousIn

visit_Arel_Nodes_HomogeneousIn has been implemented in Rails 6.1 via rails/rails@72fd0bae594 and implemented for Oracle enhanced adapter via #2013 .

Refer #2008
Fix #2072

to use `visit_Arel_Nodes_HomogeneousIn`

`visit_Arel_Nodes_HomogeneousIn` has been implemented in Rails 6.1
via rails/rails@72fd0bae594
and implemented for Oracle enhanced adapter via rsim#2013 .

Refer rsim#2008
Fix rsim#2072
@yahonda yahonda changed the title [WIP] Remove visit_Arel_Nodes_NotIn and visit_Arel_Nodes_In visitors Remove visit_Arel_Nodes_NotIn and visit_Arel_Nodes_In visitors Dec 15, 2020
@yahonda yahonda merged commit e60e9ca into rsim:master Dec 15, 2020
yahonda added a commit to yahonda/oracle-enhanced that referenced this pull request Dec 15, 2020
Remove `visit_Arel_Nodes_NotIn` and `visit_Arel_Nodes_In` visitors
yahonda added a commit that referenced this pull request Dec 15, 2020
Merge pull request #2075 from yahonda/diag_2072
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NoMethodError: undefined method `length' for #<Arel::Nodes::SelectStatement:0x00007f1640044518>

1 participant