Limit number of expressions in a list during a "homogenous in" operation #2013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ActiveRecord version 6.1.0.alpha - This fixes the following test failure: OracleEnhancedAdapter eager loading should load included association with more than 1000 records - The solution was to implement visit_Arel_Nodes_HomogeneousIn - See rails/rails@72fd0ba for the "homogenous in" explanation
Collaborator
|
Thank you for your contribution. Going forward, it would be appreciated if you open another pull request for fixing a typo. |
yahonda
added a commit
to yahonda/oracle-enhanced
that referenced
this pull request
Dec 15, 2020
to use `visit_Arel_Nodes_HomogeneousIn` `visit_Arel_Nodes_HomogeneousIn` has been implemented in Rails 6.1 via rails/rails@72fd0bae594 and implemented for Oracle enhanced adapter via rsim#2013 . Refer rsim#2008 Fix rsim#2072
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inoperation which can be performed under certain circumstances.visit_Arel_Nodes_HomogeneousIn.