Cleanup the launch_testing_examples. (backport #374) #394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Cleanup the launch_testing_examples. This is to make them more robust when run in parallel with other tests. In particular, we make sure that the tests cleanup after themselves, and we also increase the timeouts to 15 seconds. Signed-off-by: Chris Lalancette <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]> (cherry picked from commit 7e07d22)
mergify
bot
requested review from
adityapande-1995 and
ahcorde
as code owners
Contributor
|
Pulls: #394
|
Contributor
|
Linux-rhel warnings are unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to make them more robust when run in parallel with other tests. In particular, we make sure that the tests cleanup after themselves, and we also increase the timeouts to 15 seconds.
This should improve some of the flaky tests in this package, like we see in https://ci.ros2.org/view/nightly/job/nightly_linux_repeated/3385/#showFailuresLink
This is an automatic backport of pull request #374 done by Mergify.
This fixes #391