-
Notifications
You must be signed in to change notification settings - Fork 5
Compatibility with 1.75 #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
1a9cdb0
Use resolver v2 for compatibility with 1.75
mxgrey a533fe9
Add CI for linux that includes 1.75 and the latest stable version
mxgrey 604634b
Remove lockfiles from git history
mxgrey 13710ef
Add ros distros
mxgrey 15b945d
Fix workflow syntax
mxgrey 5fe2832
Use dtolnay to install rust
mxgrey e7575ed
Source ROS before building
mxgrey 9d37c86
Ensure arbitrary characters remain within ascii range
mxgrey 873aa80
Add documentation to explain generate_ascii
mxgrey File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,75 @@ | ||
name: Rust Minimal | ||
|
||
on: | ||
push: | ||
branches: [ main ] | ||
pull_request: | ||
branches: [ main ] | ||
schedule: | ||
# Run the CI at 01:22 UTC every Tuesday | ||
# We pick an arbitrary time outside of most of the world's work hours | ||
# to minimize the likelihood of running alongside a heavy workload. | ||
- cron: '22 1 * * 2' | ||
|
||
env: | ||
CARGO_TERM_COLOR: always | ||
|
||
jobs: | ||
build: | ||
strategy: | ||
matrix: | ||
ros_distribution: | ||
- humble | ||
- jazzy | ||
- kilted | ||
- rolling | ||
include: | ||
# Humble Hawksbill (May 2022 - May 2027) | ||
- docker_image: rostooling/setup-ros-docker:ubuntu-jammy-ros-humble-ros-base-latest | ||
ros_distribution: humble | ||
ros_version: 2 | ||
# Jazzy Jalisco (May 2024 - May 2029) | ||
- docker_image: rostooling/setup-ros-docker:ubuntu-noble-ros-jazzy-ros-base-latest | ||
ros_distribution: jazzy | ||
ros_version: 2 | ||
# Kilted Kaiju (May 2025 - Dec 2026) | ||
- docker_image: rostooling/setup-ros-docker:ubuntu-noble-ros-kilted-ros-base-latest | ||
ros_distribution: kilted | ||
ros_version: 2 | ||
# Rolling Ridley (June 2020 - Present) | ||
- docker_image: rostooling/setup-ros-docker:ubuntu-noble-ros-rolling-ros-base-latest | ||
ros_distribution: rolling | ||
ros_version: 2 | ||
|
||
runs-on: ubuntu-latest | ||
continue-on-error: ${{ matrix.ros_distribution == 'rolling' }} | ||
container: | ||
image: ${{ matrix.docker_image }} | ||
steps: | ||
- uses: actions/checkout@v4 | ||
|
||
- name: Setup ROS environment | ||
uses: ros-tooling/[email protected] | ||
with: | ||
required-ros-distributions: ${{ matrix.ros_distribution }} | ||
use-ros2-testing: ${{ matrix.ros_distribution == 'rolling' }} | ||
|
||
- name: Setup Rust | ||
uses: dtolnay/[email protected] | ||
with: | ||
components: clippy, rustfmt | ||
|
||
- name: Test default features | ||
run: | | ||
. /opt/ros/${{ matrix.ros_distribution }}/setup.sh | ||
cargo test --workspace | ||
|
||
- name: Test with serde | ||
run: | | ||
. /opt/ros/${{ matrix.ros_distribution }}/setup.sh | ||
cargo test --workspace -F=serde | ||
|
||
- name: Build docs | ||
run: | | ||
. /opt/ros/${{ matrix.ros_distribution }}/setup.sh | ||
cargo doc --all-features |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,75 @@ | ||
name: Rust Stable | ||
|
||
on: | ||
push: | ||
branches: [ main ] | ||
pull_request: | ||
branches: [ main ] | ||
schedule: | ||
# Run the CI at 01:22 UTC every Tuesday | ||
# We pick an arbitrary time outside of most of the world's work hours | ||
# to minimize the likelihood of running alongside a heavy workload. | ||
- cron: '22 1 * * 2' | ||
|
||
env: | ||
CARGO_TERM_COLOR: always | ||
|
||
jobs: | ||
build: | ||
strategy: | ||
matrix: | ||
ros_distribution: | ||
- humble | ||
- jazzy | ||
- kilted | ||
- rolling | ||
include: | ||
# Humble Hawksbill (May 2022 - May 2027) | ||
- docker_image: rostooling/setup-ros-docker:ubuntu-jammy-ros-humble-ros-base-latest | ||
ros_distribution: humble | ||
ros_version: 2 | ||
# Jazzy Jalisco (May 2024 - May 2029) | ||
- docker_image: rostooling/setup-ros-docker:ubuntu-noble-ros-jazzy-ros-base-latest | ||
ros_distribution: jazzy | ||
ros_version: 2 | ||
# Kilted Kaiju (May 2025 - Dec 2026) | ||
- docker_image: rostooling/setup-ros-docker:ubuntu-noble-ros-kilted-ros-base-latest | ||
ros_distribution: kilted | ||
ros_version: 2 | ||
# Rolling Ridley (June 2020 - Present) | ||
- docker_image: rostooling/setup-ros-docker:ubuntu-noble-ros-rolling-ros-base-latest | ||
ros_distribution: rolling | ||
ros_version: 2 | ||
|
||
runs-on: ubuntu-latest | ||
continue-on-error: ${{ matrix.ros_distribution == 'rolling' }} | ||
container: | ||
image: ${{ matrix.docker_image }} | ||
steps: | ||
- uses: actions/checkout@v4 | ||
|
||
- name: Setup ROS environment | ||
uses: ros-tooling/[email protected] | ||
with: | ||
required-ros-distributions: ${{ matrix.ros_distribution }} | ||
use-ros2-testing: ${{ matrix.ros_distribution == 'rolling' }} | ||
|
||
- name: Setup Rust | ||
uses: dtolnay/rust-toolchain@stable | ||
with: | ||
components: clippy, rustfmt | ||
|
||
- name: Test default features | ||
run: | | ||
. /opt/ros/${{ matrix.ros_distribution }}/setup.sh | ||
cargo test --workspace | ||
|
||
- name: Test with serde | ||
run: | | ||
. /opt/ros/${{ matrix.ros_distribution }}/setup.sh | ||
cargo test --workspace -F=serde | ||
|
||
- name: Build docs | ||
run: | | ||
. /opt/ros/${{ matrix.ros_distribution }}/setup.sh | ||
cargo doc --all-features |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
[workspace] | ||
members = ["rosidl_runtime_rs"] | ||
resolver = "3" | ||
resolver = "2" | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey sorry for the intrusion. I was taking a look at ros2_rust's examples and following the instructions for setting up the workspace led me to this error (resolver 3 not available for 1.75).
Going in with this PR would be great so as to build the workspace from scratch without issues, especially for newcomers.