-
Notifications
You must be signed in to change notification settings - Fork 5
Compatibility with 1.75 #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
Apparently we were never running the tests for this package with the |
Signed-off-by: Michael X. Grey <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good to me, though I'd feel more comfortable if a second maintainer could have a look since I'm not the most experienced with workflows
@@ -1,3 +1,3 @@ | |||
[workspace] | |||
members = ["rosidl_runtime_rs"] | |||
resolver = "3" | |||
resolver = "2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey sorry for the intrusion. I was taking a look at ros2_rust's examples and following the instructions for setting up the workspace led me to this error (resolver 3 not available for 1.75).
Going in with this PR would be great so as to build the workspace from scratch without issues, especially for newcomers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a maintainer but anything that adds CI and proves to build correctly sounds like a good idea and upstream development on rclrs
is effectively blocked until this repo works correctly, so even if there are any issues I'd suggest merging this first and fixing them in followups.
The only possible error surface is really the code in string.rs
that looks sensible to me.
Agreed, sorry for the delay on this PR everybody. I did screw up during the merge though and didn't squash the commits. Apologies (again) all I updated the repo settings so that won't happen again |
Some recent updates to this repo have led to CI failing in rclrs for the minimal Rust version 1.75.
This PR aims to fix it via the following:
Cargo.toml
(2 instead of 3)Cargo.lock
files so they don't create confusion for older versions of Rust