feat(ConnectionType) support bi-directional pagination #960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Existing argument def
Add validation for Query Name
current would throw: GraphQL::Schema::InvalidTypeError (Query is invalid: field "foo" argument "category" Variable id of type "String!" is required and will not use the default value. Perhaps you meant to use type "String".)
Update arguments.md
Raise when both query string and document are provided to Query
…RelationConnection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
has*Pageis always false for the reverse direction.Now, you can set
And graphql-ruby will provide real values for reverse-direction
has*Pagechecks. This will become the default behavior in a future graphql-ruby version. (But it is not the default behavior now because it has performance implications.)Fixes #955