Existing argument def #948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuorig
commented
Sep 11, 2017
| return type_or_argument.redefine(name: name.to_s) | ||
| end | ||
|
|
||
| argument = if block_given? |
Contributor
Author
There was a problem hiding this comment.
should we handle a block when provided an existing arg? Redefine attributes in the block 🤔 ? That might be confusing.
Owner
There was a problem hiding this comment.
It might come in handy, but I'm happy to leave it for later.
We do it for fields but it makes more sense there because some things (like argument) must be defined in the block.
Owner
|
Thanks for taking care of this one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#933
Allows defining an argument from an existing argument a bit like it's already possible with fields.