Skip to content

make BigInt.fromFloat error-safe #7419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 4, 2025
Merged

make BigInt.fromFloat error-safe #7419

merged 2 commits into from
May 4, 2025

Conversation

bloodyowl
Copy link
Collaborator

fixes #7089

⚠️ breaking change

@bloodyowl
make fromFloat error-safe
8a7d752 
fixes #7089

⚠️ breaking change
@bloodyowl bloodyowl force-pushed the bigint-from-float branch from 2ae11f1 to 8a7d752 Compare May 4, 2025 15:19
@bloodyowl bloodyowl mentioned this pull request May 4, 2025
Closed
@bloodyowl bloodyowl requested review from cknitt and cometkim May 4, 2025 15:20
@bloodyowl bloodyowl changed the title make fromFloat error-safe make BigInt.fromFloat error-safe May 4, 2025
cknitt
cknitt reviewed May 4, 2025
View reviewed changes
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented May 4, 2025 •
edited
Loading

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7419

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7419

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7419

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7419

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7419

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7419

commit: 9ba8081

@bloodyowl bloodyowl merged commit 955b9ae into master May 4, 2025
21 checks passed
@bloodyowl bloodyowl deleted the bigint-from-float branch May 4, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cknitt cknitt cknitt approved these changes

@cometkim cometkim Awaiting requested review from cometkim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transformation from float to bigint
2 participants
@bloodyowl @cknitt