-
Notifications
You must be signed in to change notification settings - Fork 469
Transformation from float to bigint #7089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Potential fix: let fromFloat = t => t->Core__Int.fromFloat->fromInt with some documentation in the interface file, maybe adapting what's already available for |
@remitbri issue there is that it accepts values above the maximum safe int32 provided they don't have any decimals, not much we can do on the type level |
Er, not sure I'm following you about the type level. This is a compiling-to-js issue |
bloodyowl
added a commit
that referenced
this issue
May 4, 2025
* make fromFloat error-safe fixes #7089⚠️ breaking change * shadow rather than prefix with underscore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
At the moment
is compiled to
Problem: in JS,
BigInt(x)
is valid only if x is an integer, not a float, so runningvar bigF = BigInt(1.3)
throws an errorThe text was updated successfully, but these errors were encountered: