Skip to content

Fix validateWebhook backwards incompatibility with older Node.js #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattt merged 2 commits into from
Aug 29, 2024
Merged

Fix validateWebhook backwards incompatibility with older Node.js #298

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8f6d78
Use backward compatible syntax for accessing object keys on requestDa…
Aug 28, 2024
5f9ecb9
Stringifying requestData.body when it is of type object. This is bac…
Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions lib/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,15 @@ async function validateWebhook(requestData, secret) {
const signingSecret = secret || requestData.secret;

if (requestData && requestData.headers && requestData.body) {
id = requestData.headers.get("webhook-id");
timestamp = requestData.headers.get("webhook-timestamp");
signature = requestData.headers.get("webhook-signature");
id =
requestData.headers["webhook-id"] ||
requestData.headers.get?.("webhook-id");
timestamp =
requestData.headers["webhook-timestamp"] ||
requestData.headers.get?.("webhook-timestamp");
signature =
requestData.headers["webhook-signature"] ||
requestData.headers.get?.("webhook-signature");
body = requestData.body;
}

Expand All @@ -49,6 +55,8 @@ async function validateWebhook(requestData, secret) {
}
} else if (isTypedArray(body)) {
body = await new Blob([body]).text();
} else if (typeof body === "object") {
body = JSON.stringify(body);
} else if (typeof body !== "string") {
throw new Error("Invalid body type");
}
Expand Down