Fix validateWebhook backwards incompatibility with older Node.js
#298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 27, 2024 20:28
…ward compatibility for Next.js 12.1.x / Node.js v18
Contributor
|
Thanks, @jakedahn! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes: #297
To make the
validateWebhookfunction backward compatible with Node.js 18.x and Next.js 12.x, we need to access the headers with a slightly different syntax.After making that adjustment, I also discovered a version incompatibility with the
requestData.bodyvalue. I fixed that by stringifying therequestData.body, and then thevalidateWebhookfunction started working as expected.