Wrap required arguments up together #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeke
reviewed
Mar 7, 2023
Member
|
(I changed the base branch on the PR to keep the redundant commits out and make this easier to review.) |
For now we only have `input`, but this allows us to change the API in future and matches the API more directly.
erbridge
force-pushed
the
required-args-object
branch
from
8bc0925 to
3289513
Compare
zeke
approved these changes
Mar 10, 2023
Member
zeke
left a comment
zeke
left a comment
There was a problem hiding this comment.
Let's give this a go and see how it feels to use it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now we only have
input, but this allows us to change the API in future and matches the API more directly.Builds on #18 to avoid conflicts.