Skip to content

Conversation

@erbridge
Copy link
Contributor

Resolves #17

@erbridge erbridge requested a review from zeke February 28, 2023 12:41
Copy link
Member

@zeke zeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see the thinking behind introducing a webhook object for tidiness, but we might be painting ourselves into a corner here, in that we'd be deviating from the OpenAPI specification. If users were to create a prediction using a generated method that maps to the create a prediction REST API operation, I would expect it to look something more like this:

{
  input: {}
  webhook: `example.com`
  webhookEventsFilter: ['output', 'completed']
}

Copy link
Member

@zeke zeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the changes. Looks good!

@erbridge erbridge enabled auto-merge (rebase) March 9, 2023 14:19
@erbridge erbridge merged commit 5eccd13 into main Mar 9, 2023
@erbridge erbridge deleted the webhooks branch March 9, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

webhook support

4 participants