Skip to content
This repository was archived by the owner on Jun 26, 2024. It is now read-only.

Conversation

ldimaggi
Copy link
Contributor

@ldimaggi ldimaggi commented Oct 8, 2019

This pull request eliminates this feedback to users - which might cause confusion for new users:

 ==   -  STEP 1/5 -   ==  
  -  Cleanup process  -  
error: unable to recognize "../../hack/yamls/service-mesh-control-plane.yaml": no matches for kind "ServiceMeshControlPlane" in version "maistra.io/v1"
error: unable to recognize "../../hack/yamls/service-mesh-member-roll.yaml": no matches for kind "ServiceMeshMemberRoll" in version "maistra.io/v1"
Error from server (NotFound): error when deleting "../../hack/yamls/knative-serving.yaml": namespaces "knative-serving" not found
unable to recognize "../../hack/yamls/knative-serving.yaml": no matches for kind "KnativeServing" in version "serving.knative.dev/v1alpha1"

@codecov
Copy link

codecov bot commented Oct 8, 2019

Codecov Report

Merging #199 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #199   +/-   ##
=======================================
  Coverage   63.22%   63.22%           
=======================================
  Files          13       13           
  Lines         862      862           
=======================================
  Hits          545      545           
  Misses        241      241           
  Partials       76       76

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc475ea...d5bab4d. Read the comment docs.

@akashshinde
Copy link
Contributor

@ldimaggi +1
/lgtm

@akashshinde
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akashshinde

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit ec8ab81 into redhat-developer:master Oct 9, 2019
akashshinde added a commit to akashshinde/service-binding-operator that referenced this pull request Oct 14, 2019
* origin/master:
  Unify and split logging into levels to reduce log flooding in production (redhat-developer#195)
  Fix operator uninstallers in example commons. (redhat-developer#202)
  Add go version in go.mod (redhat-developer#201)
  Alter the Makefile commons output to be more readable (redhat-developer#198)
  update GolangCI Lint version (redhat-developer#200)
  Update golang, kubectl, and operator-sdk version to latest in CI (redhat-developer#194)
  Minor changes to improve feedback to users when running examples (redhat-developer#199)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants