This repository was archived by the owner on Jun 26, 2024. It is now read-only.
Unify and split logging into levels to reduce log flooding in production #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good one! |
|
/test e2e |
Codecov Report
@@ Coverage Diff @@
## master #195 +/- ##
==========================================
+ Coverage 63.22% 63.36% +0.13%
==========================================
Files 13 13
Lines 862 868 +6
==========================================
+ Hits 545 550 +5
- Misses 241 242 +1
Partials 76 76
Continue to review full report at Codecov.
|
…ocal make target to pass it to the operator.
|
/test lint |
pmacik
changed the title
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbose78 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
akashshinde
added a commit
to akashshinde/service-binding-operator
that referenced
this pull request
Oct 14, 2019
* origin/master: Unify and split logging into levels to reduce log flooding in production (redhat-developer#195) Fix operator uninstallers in example commons. (redhat-developer#202) Add go version in go.mod (redhat-developer#201) Alter the Makefile commons output to be more readable (redhat-developer#198) update GolangCI Lint version (redhat-developer#200) Update golang, kubectl, and operator-sdk version to latest in CI (redhat-developer#194) Minor changes to improve feedback to users when running examples (redhat-developer#199)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The operator logs everything to console with the
infolevel of verbosity - incl. information that should be logged on thedebuglevel. That not only makes the log too verbose and unreadable but generally has a significant impact on performance and footprint.That's why the logging should be split into various levels (such as Error, Warning, Info, Debug, Trace... ( https://dave.cheney.net/2015/11/05/lets-talk-about-logging )) and only use levels Info and below in the "production".
This PR: