refactor: apply more strict types to ReplaceTransition #812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After this PR, I'll work on creating |
eps1lon
reviewed
Apr 5, 2022
src/ReplaceTransition.tsx
Outdated
| const { | ||
| children, | ||
| in: inProp, | ||
| onEnter: _onEnter, |
There was a problem hiding this comment.
Is the rename here only for ESLint? If so, then we should configure the rule appropriately. I remember there was an option specifically for rest-spread.
eps1lon
approved these changes
May 2, 2022
koba04
added a commit
that referenced
this pull request
May 3, 2022
* refactor: apply more strict types to ReplaceTransition * lint: enable the ignoreRestSiblings option of no-unused-vars
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up PR of #809.
I've applied more strict types to ReplaceTransion, which couldn't be done at #809 to avoid being treated as add/remove because of many diffs.