refactor: migrate src/ to TypeScript
#809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koba04
changed the title
koba04
changed the title
src/ to TypeScript
|
Can you reduce the diffs of the files that are not properly recognized as movied? It's IMO fine if we use a lot of |
|
After this PR has been merged, I'll update |
|
@eps1lon Thank you for your feedback; I've made all changes as renames. |
koba04
added a commit
that referenced
this pull request
May 3, 2022
* build: add tsx files as targets of Babel * refactor: migrate ChildMapping to TypeScript * refactor: add types for TransitionGroupContext * refactor: migrate SwitchTransition to TypeScript * refactor: migrate Transition to TypeScript * refactor: migrate CSSTransition to TypeScript * refactor: migrate TransitionGroup to TypeScript * refactor: migrate ReplaceTransition to TypeScript * chore: update size-snapshot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've migrated all JS files in
src/to TypeScript.This doesn't create
.d.tsfiles, so I'll work on it as a subsequent PR.Some implementations were hard to type. I've put
@ts-expect-errorcomments for them and expect them to be fixed later.I also won't fix errors by the
propTypesdefinitions because I'll removepropTypessupport in the future release.This is a starting point for TypeScript migration and I expect the types to get better.