Skip to content

Conversation

@6by9
Copy link
Contributor

@6by9 6by9 commented Jan 31, 2022

HVS5 supports the 210101010 RGB[A|X] formats, but they were
missing from the DRM to HVS mapping list, so weren't available.
Add them in.

Signed-off-by: Dave Stevenson [email protected]

HVS5 supports the 210101010 RGB[A|X] formats, but they were
missing from the DRM to HVS mapping list, so weren't available.
Add them in.

Signed-off-by: Dave Stevenson <[email protected]>
@6by9
Copy link
Contributor Author

6by9 commented Jan 31, 2022

@jc-kynesim

@popcornmix
Copy link
Collaborator

What should I run to test this? I tried:

modetest -M vc4 -F tiles,gradient -s 32:1920x1080-60 -P99@82:3840x2160+0+0@XR30

But the dlist shows:

pixel_format (04-00): value: 0x00000007 decimal:          7 mask:(0x00000007) bits(0x0000001f) 'RGBA:8:8:8:8'

so I think this format is not getting through.

@popcornmix
Copy link
Collaborator

Scratch that - there's a second layer that looks right.

                            pixel_format (04-00): value: 0x00000010 decimal:         16 mask:(0x00000010) bits(0x0000001f) 'RGB:10:10:2'

@6by9
Copy link
Contributor Author

6by9 commented Jan 31, 2022

modetest -M vc4 -P 80@88:1280x800@AB30
was my test, with also AR30, XR30, and XB30.

@jc-kynesim
Copy link
Contributor

jc-kynesim commented Jan 31, 2022

Well I can now drive AR30 from my drm test prog and I can confirm that alpha works and colours are where I expect them.
Also works fine if the output monitor can't do 10 bit

@pelwell pelwell merged commit 1f26721 into raspberrypi:rpi-5.10.y Jan 31, 2022
popcornmix added a commit to raspberrypi/firmware that referenced this pull request Feb 2, 2022
kernel: Patching lan78xx for SOF_TIMESTAMPING_TX_SOFTWARE support
See: raspberrypi/linux#4856

kernel: i2c: bcm2835: Make clock-stretch timeout configurable
See: raspberrypi/linux#4855

kernel: drm/vc4: Add DRM 210101010 RGB formats for hvs5.
See: raspberrypi/linux#4859

kernel: vc4-kms-dpi overlay updates
See: raspberrypi/linux#4860

kernel: Add Support for the Geekworm MZP280 DPI Display
See: raspberrypi/linux#4853

kernel: DRM: Clean up handling of panel orientation
See: raspberrypi/linux#4862

kernel: Add support for the MAX30102 heart rate and blood oxygen sensor
See: raspberrypi/linux#4535

firmware: mmal: Add mapping for IL OMX_IndexParamBrcmEnableIJGTableScaling param
See: raspberrypi/linux#4669

userland: Handle overlay parameters embedded in overlay_map.dtb
See: raspberrypi/linux#4860
popcornmix added a commit to raspberrypi/rpi-firmware that referenced this pull request Feb 2, 2022
kernel: Patching lan78xx for SOF_TIMESTAMPING_TX_SOFTWARE support
See: raspberrypi/linux#4856

kernel: i2c: bcm2835: Make clock-stretch timeout configurable
See: raspberrypi/linux#4855

kernel: drm/vc4: Add DRM 210101010 RGB formats for hvs5.
See: raspberrypi/linux#4859

kernel: vc4-kms-dpi overlay updates
See: raspberrypi/linux#4860

kernel: Add Support for the Geekworm MZP280 DPI Display
See: raspberrypi/linux#4853

kernel: DRM: Clean up handling of panel orientation
See: raspberrypi/linux#4862

kernel: Add support for the MAX30102 heart rate and blood oxygen sensor
See: raspberrypi/linux#4535

firmware: mmal: Add mapping for IL OMX_IndexParamBrcmEnableIJGTableScaling param
See: raspberrypi/linux#4669

userland: Handle overlay parameters embedded in overlay_map.dtb
See: raspberrypi/linux#4860
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants